After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758604 - Make gudev support not automagic
Make gudev support not automagic
Status: RESOLVED FIXED
Product: clutter-gst
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: clutter-gst-maint
clutter-gst-maint
Depends on:
Blocks:
 
 
Reported: 2015-11-24 15:57 UTC by Gilles Dartiguelongue
Modified: 2015-11-24 17:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make libgudev support switchable by configure switch (1.72 KB, patch)
2015-11-24 15:57 UTC, Gilles Dartiguelongue 		accepted-commit_now Details | Review

Description Gilles Dartiguelongue 2015-11-24 15:57:02 UTC 
Created attachment 316181 [details] [review]
Make libgudev support switchable by configure switch

Hello,

current support of gudev in clutter-gst is automagic, meaning it can be either on or off depending on system it is being built on and not according to user wishes.

See also https://wiki.gentoo.org/wiki/Project:Quality_Assurance/Automagic_dependencies

Here is a patch that will add support for properly being able to switch it on or off while keeping the default automatic support as most upstreams wish.
Comment 1 Lionel Landwerlin 2015-11-24 16:00:05 UTC 
Review of attachment 316181 [details] [review]:

Looks good.
Comment 2 Emmanuele Bassi (:ebassi) 2015-11-24 16:01:47 UTC 
The usual pattern for feature flags is to use AC_ARG_ENABLE, not AC_ARG_WITH.

The --with-foo switch is to enable specific values of 'foo' like --with-foo=/path/to/foo.
Comment 3 Lionel Landwerlin 2015-11-24 16:19:58 UTC 
Pushed a slightly different version based on Emmanuele's comment.
Thanks!
Comment 4 Gilles Dartiguelongue 2015-11-24 17:29:25 UTC 
Thanks guys.
Comment 5 Gilles Dartiguelongue 2015-11-24 17:31:22 UTC 
Looks like this occurrence was missed though: https://github.com/GNOME/clutter-gst/blob/clutter-gst-3.0/configure.ac#L228
Comment 6 Lionel Landwerlin 2015-11-24 17:34:29 UTC 
Done, thanks.