After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758599 - documents: Fix run-time warning
documents: Fix run-time warning
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-11-24 13:57 UTC by Bastien Nocera
Modified: 2015-11-25 16:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
documents: Fix run-time warning (1.45 KB, patch)
2015-11-24 13:57 UTC, Bastien Nocera 		committed Details | Review
shellSearchProvider: Fix run-time warning (1.20 KB, patch)
2015-11-25 10:51 UTC, Debarshi Ray 		committed Details | Review

Description Bastien Nocera 2015-11-24 13:57:21 UTC 
.
Comment 1 Bastien Nocera 2015-11-24 13:57:24 UTC 
Created attachment 316168 [details] [review]
documents: Fix run-time warning

In newer versions of gtk+, gtk_icon_theme_lookup_by_gicon_for_scale()
will warn if somebody uses GTK_ICON_LOOKUP_GENERIC_FALLBACK with
functions that don't support it.

See 8ec2362d in GTK+.

(org.gnome.Books:7975): Gtk-WARNING **: (gtkicontheme.c:5440):gtk_icon_theme_lookup_by_gicon_for_scale: runtime check failed: ((flags & GTK_ICON_LOOKUP_GENERIC_FALLBACK) == 0)
Comment 2 Cosimo Cecchi 2015-11-25 01:41:43 UTC 
Review of attachment 316168 [details] [review]:

Looks good to me, thanks.
Comment 3 Bastien Nocera 2015-11-25 09:15:37 UTC 
Attachment 316168 [details] pushed as fc36cbb - documents: Fix run-time warning
Comment 4 Debarshi Ray 2015-11-25 10:51:05 UTC 
There is one more.
Comment 5 Debarshi Ray 2015-11-25 10:51:35 UTC 
Created attachment 316227 [details] [review]
shellSearchProvider: Fix run-time warning
Comment 6 Bastien Nocera 2015-11-25 13:23:34 UTC 
Review of attachment 316227 [details] [review]:

Sure.
Comment 7 Debarshi Ray 2015-11-25 16:19:39 UTC 
Comment on attachment 316227 [details] [review]
shellSearchProvider: Fix run-time warning

Thanks, Bastien. Pushed to master.