GNOME Bugzilla – Bug 758586
mssdemux: missing depth in audio caps
Last modified: 2015-11-24 18:05:19 UTC
Created attachment 316155 [details] [review]
Our sink reconstructs WAVEFORMATEX structure for WMA and WMA Pro audio from provided caps.
Problem is that mssdemux, doesn't set 'depth' field in audio caps, which is necessary to reconstruct WAVEFORMATEX.
Because of this, are following samples with WMA Pro on our HW without sound:
I suggest to retrieve 'depth' from "WaveFormatEx" if it's available in Manifest and set it in caps.
So I find out, that we can also retrieve depth from "BitsPerSample" in Manifest.
Created attachment 316159 [details] [review]
updated first patch
Author: Maroš Ondrášek <firstname.lastname@example.org>
Date: Tue Nov 24 11:50:51 2015 +0100
mssdemux: add depth field to audio caps if available
depth field can be retrieved from "BitsPerSample" or
from "WaveFormatEx" structure, if provided in Manifest
I'm a bit confused, wasn't depth field removed between 0.10 and 1.0 ?
(In reply to Nicolas Dufresne (stormer) from comment #4)
> I'm a bit confused, wasn't depth field removed between 0.10 and 1.0 ?
For raw audio, yes. It is still used in some encoded formats.