GNOME Bugzilla – Bug 758579
Undo/Redo operation forget on copy of directories
Last modified: 2016-01-08 08:23:27 UTC
Recently, I found the one bug releated with Undo/Redo feature of Nautilus. How to reproduce the bug: Let's say, there are three directories called a, b, c under the same directory. Op 1. Copy a to b Op 2. Under the Edit menu, do "Undo Copy". Op 3. Copy c to b 4. Under the Edit menu, You can see "Redo copy" for Op 1 is enabled Excepted result: I think "Undo Copy" for Op 3 should be enabled under the Edit menu. Hope to any direction to solve this issue.
I fixed this issue. Let me know where can i upload the patch.
Hey, Thanks for it. Upload the patch here and I'll glad to have a look.
ah sorry, this was fixed already :)
Ok, I marked this issue to Fixed resolved by myself, but this issue was not fixed in the official version. So I will upload the patch here so that you can check, I 've worked on the nautilus 3.4.2.
Created attachment 318303 [details] [review] Worked on Nautilus 3.4.2, Need for review
Review of attachment 318303 [details] [review]: thanks for the patch! It doesn't look like the right approach tho. ::: nautilus-3.4.2.orig/libnautilus-private/nautilus-file-operations.c @@ +197,2 @@ #define ZEITGEIST_NAUTILUS_ACTOR "application://nautilus.desktop" +#define LGI_2015_12_24 What is this? @@ +4784,3 @@ g_object_unref (src_dir); } +#else You are just bypassing the undo_manager_pop_flag? That looks wrong, it's there for a reason.
Yes, I am just bypassing the undo_manager_pop_flag(). What do you recommend to fix this error?
Thanks for your review. This flag is for checking for undo/redo status as you know. So, I should take one period of Undo copy and Redo copy during the the copy operation thus the another copy operation cannot effect the current copy operation, after all current bug was occured. So, I bypassed the undo_manager_pop_flag() operation in the copy operation. I've already confirmed that current patch fixed the bug. This approach makes sense?
Sorry for the confusion all. I 've made the status of issue as incomplete status again.