After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758509 - Allow fractional page duration
Allow fractional page duration
Product: evince
Classification: Core
Component: general
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Reported: 2015-11-22 22:23 UTC by Marc Vinyals
Modified: 2018-05-22 16:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Increase page duration resolution (581 bytes, patch)
2015-11-22 22:23 UTC, Marc Vinyals
needs-work Details | Review

Description Marc Vinyals 2015-11-22 22:23:52 UTC
Created attachment 316061 [details] [review]
Increase page duration resolution

In presentation mode, if a page duration is specified, then the viewer should advance to the next page. The current time resolution is multiples of 1 second, which is too coarse for animations where each page lasts for a fraction of a second. The attached patch changes the time resolution to multiples of 1 millisecond.
Comment 1 Carlos Garcia Campos 2015-12-02 09:51:54 UTC
Review of attachment 316061 [details] [review]:

::: libview/ev-view-presentation.c
@@ +246,3 @@
+				g_timeout_add (duration,
+					       (GSourceFunc) transition_next_page,
+					       pview);

Thanks for the patch, you are right this is not correct, since duration is a double, but it's also in seconds while g_timout_add expect milliseconds, so you need to pass duration * 1000
Comment 2 GNOME Infrastructure Team 2018-05-22 16:25:23 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: