GNOME Bugzilla – Bug 758508
Ignore duration for replace transition effect in PDF documents
Last modified: 2018-05-22 16:25:11 UTC
Created attachment 316060 [details] [review] Ignore duration for replace transition effect In the context of transitions between pages in presentation mode, according to the PDF Reference version 1.7, Table 162, if the transition type is R (Replace), then "The new page simply replaces the old one with no special transition effect; the D entry shall be ignored". The attached patch ignores the duration of the transition in that case, so that the transition has length 0.
Review of attachment 316060 [details] [review]: It looks good to me. FWIW, in the PDF 1.4 (PDF ISO 3200) it also says the same. Same table (162), page 378.
Review of attachment 316060 [details] [review]: Thanks for the patch. It looks good to me too. My only concern is that this is done in the common code, and wile it's true that only the pdf backend implements page transitions, it's supposed to be common code, so I would move this check to the backend. In pdf_document_get_effect, don't pass the duration to the constructor if the effect is replace. I think even poppler should do this actually, but I'm fine doing it in evince since poppler doesn't do it ATM. What happens when the timeline has a 0 duration? Do you have a pdf test case to try this out?
Is it possible that this is the bug causing extremely slow transition animation for some PDF files of ca. 3 seconds? If yes, is there any way to get this fixed? If no fix is possible, how about a workaround of disabling animations everywhere? With transitions of 3 seconds there is no reasonable way to use it for serious presentations.
(In reply to Christian Stadelmann from comment #3) > Is it possible that this is the bug causing extremely slow transition > animation for some PDF files of ca. 3 seconds? If yes, is there any way to > get this fixed? If no fix is possible, how about a workaround of disabling > animations everywhere? With transitions of 3 seconds there is no reasonable > way to use it for serious presentations. could you please file a new bug describing your issue and attaching a test case?
(In reply to José Aliste from comment #4) > could you please file a new bug describing your issue and attaching a test > case? See https://bugzilla.gnome.org/show_bug.cgi?id=774076.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/evince/issues/636.