After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758476 - name autocompletion doesn't work under Wayland
name autocompletion doesn't work under Wayland
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
3.18.x
Other Linux
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2015-11-21 22:45 UTC by Andreas Nilsson
Modified: 2015-11-26 16:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tabCompletion: Fix completion popup on wayland (2.30 KB, patch)
2015-11-26 16:22 UTC, Florian Müllner
committed Details | Review

Description Andreas Nilsson 2015-11-21 22:45:27 UTC
To reproduce:
1. Run the wayland session
2. Start Polari
3. Join a channel
4. Try to get someone's attention by starting to write the nick and hitting tab to autocomplete.

The name blinks and you can see the full, autocompleted nick, but goes away immediately.
Comment 1 Andreas Nilsson 2015-11-22 21:08:02 UTC
so apparently it only happens if you have, say, 5 people in the same channel who's name start with the same letters, and then you try to autocomplete on those letters. Say 'av' and 'amigadave' is in the same channel.
a-tab creates the blinking
am-tab or av-tab will give the autocompletion as expected on amigadave and av each
Comment 2 Matthias Clasen 2015-11-23 19:24:46 UTC
the popup needs to be marked as transient and have a suitable window type hint set.
Comment 3 Florian Müllner 2015-11-26 16:22:15 UTC
The following fix has been pushed:
9adc8e7 tabCompletion: Fix completion popup on wayland
Comment 4 Florian Müllner 2015-11-26 16:22:20 UTC
Created attachment 316324 [details] [review]
tabCompletion: Fix completion popup on wayland

Unlike normal popups, the completion popup only serves as display for
completion options, so it does not grab input and should not take away
the focus from the corresponding entry. The latter doesn't currently
work on wayland, which makes us dismiss the popup immediately on map.

Work around this by marking the popup as tooltip (ugh), which allows
us to keep it working without taking a grab. In the future, we might
want to consider stop using a toplevel window for completions, for
instance a popover.