After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758475 - Examples fail if backend is disabled
Examples fail if backend is disabled
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-11-21 22:41 UTC by Sebastian
Modified: 2016-01-11 19:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: Make it possible to disable the backend build (745 bytes, patch)
2016-01-11 15:48 UTC, Debarshi Ray 		committed Details | Review

Description Sebastian 2015-11-21 22:41:28 UTC 
If I disable the backend with --disable-backend then I can no longer build the examples. The reason is, that REST_CFLAGS is defined in the backend section in configure.ac, and this is needed by the examples to build the lastfm example.

To resolve this there are two options:

 1. Move the REST_CFLAGS out of the backend section (in configure.ac)
 2. Make the building of examples conditional on the backend being enabled (in src/Makefile.am)
 3. Do not build the lastfm example if the backend is disabled, and probably also not if lastfm is disabled.
Comment 1 Debarshi Ray 2016-01-11 15:47:46 UTC 
(In reply to Sebastian from comment #0)
> If I disable the backend with --disable-backend then I can no longer build
> the examples. The reason is, that REST_CFLAGS is defined in the backend
> section in configure.ac, and this is needed by the examples to build the
> lastfm example.

I swear I build tested bug 751128 with both values of the option. Maybe I forgot to 'git clean -fdx' between the runs. :/

> To resolve this there are two options:
> 
>  1. Move the REST_CFLAGS out of the backend section (in configure.ac)
>  2. Make the building of examples conditional on the backend being enabled
> (in src/Makefile.am)
>  3. Do not build the lastfm example if the backend is disabled, and probably
> also not if lastfm is disabled.

I prefer (2) because it is not just REST. One of the examples really do need the backend to be built.
Comment 2 Debarshi Ray 2016-01-11 15:48:20 UTC 
Created attachment 318756 [details] [review]
build: Make it possible to disable the backend build
Comment 3 Debarshi Ray 2016-01-11 16:31:53 UTC 
Pushed to master and gnome-3-18.
Comment 4 Sebastian 2016-01-11 19:57:01 UTC 
Thank you Ray. :)