After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758469 - Overview cannot open local files
Overview cannot open local files
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Overview
3.18.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Lorenzo Tilve
Epiphany Maintainers
: 736245 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2015-11-21 20:26 UTC by Michael Catanzaro
Modified: 2016-02-07 22:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
overview: Do not show local files on the overview (3.28 KB, patch)
2016-01-26 00:19 UTC, Lorenzo Tilve
committed Details | Review
overview: Do not show local files on the overview (3.27 KB, patch)
2016-02-07 22:31 UTC, Lorenzo Tilve
committed Details | Review

Description Michael Catanzaro 2015-11-21 20:26:30 UTC
The overview can't load local files. We need to either tell the UI process over D-Bus to create a "sandbox" extension for local pages, or else make sure local pages never end up in the overview.

It's reported at <https://forums.pcbsd.org/thread-20257.html>, see Example D:

Received an unexpected URL from the web process: 'file:///usr/home/gjp4/Documents/nosh-guide-1.19/nosh//index.html'
Received an unexpected URL from the web process: 'file:///usr/home/gjp4/Documents/nosh-guide-1.19/nosh//index.html'
ASSERTION FAILED: m_process->checkURLReceivedFromWebProcess(request.url())
/wrkdirs/usr/ports/www/webkit2-gtk3/work/webkitgtk-2.8.5/Source/WebKit2/UIProcess/WebPageProxy.cpp(3080) : void WebKit::WebPageProxy::decidePolicyForNavigationAction(uint64_t, uint64_t, const WebKit::NavigationActionData &, uint64_t, const WebCore::ResourceRequest &, const WebCore::ResourceRequest &, uint64_t, const WebKit::UserData &, bool &, uint64_t &, uint64_t &, uint64_t &)
Comment 1 Lorenzo Tilve 2016-01-26 00:19:07 UTC
Created attachment 319713 [details] [review]
overview: Do not show local files on the overview
Comment 2 Lorenzo Tilve 2016-01-26 00:24:26 UTC
*** Bug 736245 has been marked as a duplicate of this bug. ***
Comment 3 Michael Catanzaro 2016-01-26 00:26:09 UTC
Review of attachment 319713 [details] [review]:

::: lib/history/ephy-history-service-urls-table.c
@@ +268,3 @@
 
+  if (query->ignore_local)
+    statement_str = g_string_append (statement_str, "urls.url NOT LIKE 'file%' AND ");

Or alternatively:

"urls.url LIKE 'http%' AND"

?

I don't see any advantages to either way.
Comment 4 Lorenzo Tilve 2016-02-07 22:31:17 UTC
Created attachment 320588 [details] [review]
overview: Do not show local files on the overview
Comment 5 Lorenzo Tilve 2016-02-07 22:34:52 UTC
Thanks for the review.

There was in fact one advantage in doing it with the suggested alternative, which was filtering out also any 'about:*' element from the overview.