Created attachment 316020 [details] [review]
genres: Simplify GtkListStore usage

Pointer arithmetic looks pretty gross, and GtkListStore has functions to
avoid needing to append an iter before inserting the values.

Created attachment 316021 [details] [review]
genres: Fix translated genre being compared to untranslated one

If you're running in French, "Classique" will be in the known genres,
but we wouldn't have seen that because we'd compare it to the
untranslated "Classic".

Review of attachment 316020 [details] [review]:

Looks good apart from comparing the untranslated genre name

Review of attachment 316021 [details] [review]:

Looks good thanks - I presume you'll squash this into the previous patch before pushing it?

(In reply to Phillip Wood from comment #4)
> Review of attachment 316021 [details] [review] [review]:
> 
> Looks good thanks - I presume you'll squash this into the previous patch
> before pushing it?

No, one is styling fixes, the other is a bug fix. I prefer to keep those separate. The first patch doesn't make any functional changes.

Attachment 316020 [details] pushed as b68c1fc - genres: Simplify GtkListStore usage
Attachment 316021 [details] pushed as 359b345 - genres: Fix translated genre being compared to untranslated one