GNOME Bugzilla – Bug 758424
v4l2videodec: Keep the input buffers, they are needed to copy metadata
Last modified: 2016-06-07 21:19:59 UTC
In the v4l2videodec element, we drop the input buffer, to avoid wasting memory. Though, this prevent the metadata from being copied later. videodecoder gstvideodecoder.c:3074:gst_video_decoder_finish_frame:<v4l2video0dec0> Can't copy metadata because input frame disappeared Extra careful note, right now we don't share the input buffer pool (it's probably not a good idea anyway), though if we did, in this case, we'd have to make sure that we have enough input buffers (basically, the the capture minimum becomes the encoded buffer minimum).
Created attachment 329344 [details] [review] v4l2videodec: Keep part of the input buffer Instead of completely getting rid of the input buffer, copy the metadata, the flags and the timestamp into an empty buffer. This way the decoder base class can copy that information again to the output buffer.
Attachment 329344 [details] pushed as 462800e - v4l2videodec: Keep part of the input buffer
Branch: 1.8 Commit: 8e155edca7cc47b9ae8b786040b92a86aefd8ff1