After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758408 - [PATCH] Use set_default_icon_name.
[PATCH] Use set_default_icon_name.
Status: RESOLVED FIXED
Product: gnome-logs
Classification: Other
Component: general
3.19.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-logs maintainer(s)
gnome-logs maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-11-20 15:39 UTC by Arnaud B.
Modified: 2015-11-26 13:41 UTC
See Also:
GNOME target: ---
GNOME version: 3.19/3.20

Attachments
Set default icon (for when app-menu is broken). (796 bytes, patch)
2015-11-20 15:39 UTC, Arnaud B. 		committed Details | Review

Description Arnaud B. 2015-11-20 15:39:18 UTC 
Created attachment 315976 [details] [review]
Set default icon (for when app-menu is broken).

When there’s no app-menu support, Gtk+ adds a menubutton at the left of the headerbar to present the app’s actions. gtk_window_set_default_icon_name() looks necessary to have the app’s icon used here, instead of a completely abstract one.
Comment 1 David King 2015-11-21 08:46:21 UTC 
Review of attachment 315976 [details] [review]:

Looks fine, although please use PACKAGE_TARNAME rather than "gnome-logs".
Comment 2 Arnaud B. 2015-11-26 13:41:05 UTC 
I commited with the modification. Thanks.