After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758394 - maybe bug: logical applied only to the left hand side
maybe bug: logical applied only to the left hand side
Status: RESOLVED FIXED
Product: libcroco
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libcroco maintainers
libcroco maintainers
Depends on:
Blocks:
 
 
Reported: 2015-11-20 12:56 UTC by Marek Chalupa
Modified: 2015-12-15 18:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix comparsion (1.38 KB, patch)
2015-12-15 17:05 UTC, Marek Chalupa 		committed Details | Review

Description Marek Chalupa 2015-11-20 12:56:51 UTC 
Hi,

today, while compiling, I noticed a warning from compiler which looks like it could be a bug

cr-sel-eng.c: In function 'lang_pseudo_class_handler':
cr-sel-eng.c:129:45: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
             || !a_sel->content.pseudo->type == FUNCTION_PSEUDO) {
Comment 1 Ignacio Casal Quinteiro (nacho) 2015-12-13 18:23:48 UTC 
Hey,

can you provide a format patch to fix it?
Comment 2 Marek Chalupa 2015-12-15 17:05:19 UTC 
Created attachment 317449 [details] [review]
fix comparsion