GNOME Bugzilla – Bug 758372
Translation comments in .ui file cut off if they contain '
Last modified: 2017-08-05 19:28:40 UTC
Hi, I noticed some translation comments that were cut off mid-sentence. Looking at the code shows that this happens as soon as there is a ' in the comment. The affected strings I have seen are in src/orca/orca-setup.ui. I see comments from .py files extracted correctly, so this is possibly some xml problem. Example: comments="Translators: If this this setting is enabled, '123' will be spoken as the individual digits '1 2 3'; otherwise, it will be sent to the synthesizer and (likely) spoken as 'one hundred and twenty three'.">Speak _numbers as digits</property> This comment is only shown as "If this this setting is enabled, " (Off-topic, but i noticed now that the word "this" is doubled there.) Most likely the cut-off issue is the same as mentioned in commit 0d5271c6379f213f1e45dba99ff5add40563297c , but it seems all comments with ' in them are affected, for example all comments with the words "Orca's" or "it's" in them are affected as well. That the comments are cut off can be seen in https://l10n.gnome.org/POT/orca.master/orca.master.pot Regards, Anders Jonsson
(In reply to Anders Jonsson from comment #0) > Most likely the cut-off issue is the same as mentioned in commit > 0d5271c6379f213f1e45dba99ff5add40563297c I see I misread that commit, so the connection is maybe not as strong as I first thought, but it's still fully possible that the problems are related.
Ugh. I'll try to get to this very soon. Unless you have time to do a patch.(?)
(In reply to Joanmarie Diggs (IRC: joanie) from comment #2) > Ugh. I'll try to get to this very soon. Unless you have time to do a > patch.(?) Seems like it is not an orca bug, I found the same problem in gcr and gnome-control-center. Some infrastructure might have changed or updated. In that case it is something that happened after August 15th, as the current sv.po for orca was created that day, and the comments of that file look OK. Will ask in #i18n if anyone has any idea what the cause might be. Strings with cut off comments in other GNOME packages: gnome-control-center: #. Translators: Opens a dialog containing printer #: ../panels/printers/printers.ui.h:11 msgid "Show _Jobs" msgstr "" #. Translators: This button opens printer #: ../panels/printers/printers.ui.h:22 msgid "_Options" msgstr "" gcr: #. Translators: The #: ../ui/gcr-unlock-options-widget.ui.h:6 msgid "minutes" msgstr "minuter"
Interesting. When I run "intltool-update sv" myself from git, the comments in ui files in orca are completely extracted without problems. This on Debian with intltool version 0.50.2-2. Reassigning the bug to damned-lies as the problem seems to happen when l10n.gnome.org creates the po and pot files. This was tested on Debian with intltool version 0.50.2-2.
CCing Attila because he was the translator who reported that his translations were not showing up in the UI, but when I tried his translations they showed up in the UI for me. I use Fedora 23; he can tell you what he uses. Anyhoo the "fix" (fingerquotes) for his issue wound up being to remove the context attributes from the .ui file. Long way of saying: Something platformy seems quite broken.
This was the earliest commit I could find that has the problem: https://git.gnome.org/browse/orca/commit/po?id=ad574d1f42d417a6a4a5f7c526475b85764a51bf (One can see in the diff that the comment for src/orca/orca-setup.ui.h:44 is being truncated) That pot file was created 2015-09-19, so the problem would seem to be some change in the infrastructure on or before that date.
This is a bug in intltool 0.51 that damned-lies (and many distros, including Fedora) uses: https://bugs.launchpad.net/intltool/+bug/1497715 Unfortunately, it doesn't seem like intltool is actively maintained these days.
Well, clearly the bug needs to be fixed where the bug is. That said, I'd much rather you all know what on earth these "strange" screen-readery things are than have proper punctuation. :) So while I was doing a bunch of other work that included the .ui file in question, I have done an apostrophectomy. @Anders: could you please tell me if that at least makes the full comments appear? Thanks!!
(In reply to Joanmarie Diggs (IRC: joanie) from comment #8) > @Anders: could you please tell me if that at least makes the full comments > appear? Thanks!! Yes, your changes works around all issues in orca as far as I can see.
(In reply to Piotr Drąg from comment #7) > This is a bug in intltool 0.51 that damned-lies (and many distros, including > Fedora) uses: > > https://bugs.launchpad.net/intltool/+bug/1497715 > > Unfortunately, it doesn't seem like intltool is actively maintained these > days. Thank you for the pointers, I found the change in question: http://bazaar.launchpad.net/~intltool/intltool/trunk/revision/735 Reverting that commit's change to intltool-extract.in fixes the comment extracting problem for me.
intltool is dead and the only thing we can do is to phase it out.