After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758349 - overrides: Allow specifying the CSS node name
overrides: Allow specifying the CSS node name
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2015-11-19 16:15 UTC by Florian Müllner
Modified: 2015-11-19 20:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
overrides: Allow specifying the CSS node name (1.40 KB, patch)
2015-11-19 16:15 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2015-11-19 16:15:14 UTC 
See patch.
Comment 1 Florian Müllner 2015-11-19 16:15:18 UTC 
Created attachment 315899 [details] [review]
overrides: Allow specifying the CSS node name

GTK+ now uses CSS node names instead of style classes for most of its
widgets. While style classes still work to customize the appearance,
subclasses may want to override that node name to not inherit any style
from the parent, so expose the functionality.
Comment 2 Cosimo Cecchi 2015-11-19 19:22:00 UTC 
Review of attachment 315899 [details] [review]:

Looks good to me, but why can't you call the API directly instead of exposing it here as an override?
Comment 3 Cosimo Cecchi 2015-11-19 19:24:46 UTC 
Review of attachment 315899 [details] [review]:

Oh, because it needs to be called in class_init. Makes sense then.
Comment 4 Florian Müllner 2015-11-19 20:05:23 UTC 
Attachment 315899 [details] pushed as c90238d - overrides: Allow specifying the CSS node name