After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758299 - signal editor: Avoid GTK+ warnings
signal editor: Avoid GTK+ warnings
Status: RESOLVED FIXED
Product: glade
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Glade 3 Maintainers
Glade 3 Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-11-18 16:52 UTC by Matthias Clasen
Modified: 2015-11-26 03:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
signal editor: Avoid GTK+ warnings (3.98 KB, patch)
2015-11-18 16:52 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2015-11-18 16:52:01 UTC 
GTK+ warns nowadays if the state passed to gtk_style_context_get_*
does not match the state of the context. Avoid this by setting
the state beforehand. This is just a bandaid fix; the drawing
should be redone in terms of gtk_render_ APIs instead of poking
at colors.
Comment 1 Matthias Clasen 2015-11-18 16:52:04 UTC 
Created attachment 315845 [details] [review]
signal editor: Avoid GTK+ warnings
Comment 2 Tristan Van Berkom 2015-11-25 10:51:35 UTC 
Review of attachment 315845 [details] [review]:

Thanks for sorting this out.

It looks like you are missing a call to gtk_style_context_restore() in one of the three blocks you updated:

if (dummy || !glade_signal_get_detail (signal))
 {
    ... added _save() missing _restore()
 }

Please verify that that is correct and commit the result.
Comment 3 Matthias Clasen 2015-11-26 03:24:37 UTC 
Thanks for catching that, fixed.

Attachment 315845 [details] pushed as 3604a2a - signal editor: Avoid GTK+ warnings