After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758268 - handle_setup_request() expect the media to be suspended
handle_setup_request() expect the media to be suspended
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
1.6.0
Other Linux
: Normal normal
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-11-18 10:11 UTC by Srimanta Panda (trollkarlen)
Modified: 2015-12-04 13:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
suspend media in setup request (1.28 KB, patch)
2015-11-18 12:24 UTC, Srimanta Panda (trollkarlen) 		committed Details | Review

Description Srimanta Panda (trollkarlen) 2015-11-18 10:11:23 UTC 
handle_setup_request() expect the media to be suspended (for example block-size from setup request will not affect preroll buffer unless the media is suspended).

This ticket is created to split the fix logically which was provided in https://bugzilla.gnome.org/show_bug.cgi?id=758179.
Comment 1 Srimanta Panda (trollkarlen) 2015-11-18 10:11:44 UTC 
I will provide a fix soon.
Comment 2 Srimanta Panda (trollkarlen) 2015-11-18 12:24:28 UTC 
Created attachment 315819 [details] [review]
suspend media in setup request
Comment 3 Sebastian Dröge (slomo) 2015-11-19 08:04:57 UTC 
After this fix, will the first RTP packet that is sent to a client have exactly the same sequence number as given in the RTSP response, and will it be exactly the first packet that was ever be created? Or are we again flushing away packets without telling the client, or flushing away the initial keyframe?

I think we should write a test for this to ensure that the first payloaded packet really arrives at the client.
Comment 4 Sebastian Dröge (slomo) 2015-12-04 13:49:35 UTC 
commit ed70572c6c0553d00add06aaf6304012bff82cb9
Author: Srimanta Panda <srimanta@axis.com>
Date:   Wed Nov 18 11:14:39 2015 +0100

    rtsp-client: suspend media during setup request
    
    SETUP request from clients needs to suspend the media to clear the
    prerolled buffers. Otherwise it will not affect the prerolled buffer
    and the prerolled buffers will be incorrect (for example block-size
    from setup request will not affect the prerolled buffer unless the
    media is suspended).
    
    https://bugzilla.gnome.org/show_bug.cgi?id=758268