After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758237 - [evdev] Buttons 4-7 should be skipped to remain compatible with x11
[evdev] Buttons 4-7 should be skipped to remain compatible with x11
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
1.20.x
Other Linux
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2015-11-17 16:52 UTC by Carlos Garnacho
Modified: 2015-11-17 21:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
evdev: Move additional pointer buttons after the old 4-7 scrolling ones (1.27 KB, patch)
2015-11-17 16:53 UTC, Carlos Garnacho 		committed Details | Review

Description Carlos Garnacho 2015-11-17 16:52:43 UTC 
This bug is similar to bug #758072 reported to gtk+, although it's probably less urgent here.

For extra pointer buttons (>3), Clutter right now assigns buttons starting at 4, however on x11 those used to be given indexes starting at 8 as buttons 4-7 were usually taken by scrolling buttons.
Comment 1 Carlos Garnacho 2015-11-17 16:53:27 UTC 
Created attachment 315767 [details] [review]
evdev: Move additional pointer buttons after the old 4-7 scrolling ones

On X11 those were skipped, so additional pointer buttons would come up
as button >= 8 events. Do here the same, so we remain compatible across
backends.
Comment 2 Emmanuele Bassi (:ebassi) 2015-11-17 17:15:36 UTC 
Review of attachment 315767 [details] [review]:

Okay.

::: clutter/evdev/clutter-device-manager-evdev.c
@@ +591,3 @@
     }
 
+  if (G_UNLIKELY (button_nr < 1 || button_nr > 12))

Drop the unlikely — it's unnecessary.
Comment 3 Carlos Garnacho 2015-11-17 21:48:18 UTC 
Attachment 315767 [details] pushed as 83b738c - evdev: Move additional pointer buttons after the old 4-7 scrolling ones