GNOME Bugzilla – Bug 758233
mpdparser: remove unused functions gst_mpdparser_get_chunk_by_index and gst_mpdparser_find_segment_by_index
Last modified: 2015-11-19 19:06:30 UTC
gst_mpdparser_get_chunk_by_index and gst_mpdparser_find_segment_by_index are unused. Should we remove them? If we decide to keep them, there are a few problems to be fixed: - gst_mpdparser_find_segment_by_index does not set the repeat field. - gst_mpdparser_get_chunk_by_index, when asked to retrieve chunk indexChunk, will retrieve the next one (the first thing it does is to increment indexChunk). The function has no comments and is not used, so I can't figure out if this is correct or not. From an API point of view, is completely non-intuitive. Once a decision to remove/fix is taken, I can implement the changes.
I'd just remove those, there were lots of changes to accommodate the template generation and repeated entries to use less memory. Those look like leftovers after those changes.
Created attachment 315898 [details] [review] proposed patch
commit ef84f294c01bcc0b0fc88a872937806154e0283a Author: Florin Apostol <florin.apostol@oregan.net> Date: Thu Nov 19 15:59:56 2015 +0000 mpdparser: remove unused functions gst_mpdparser_get_chunk_by_index and gst_mpdparser_find_segment_by_index https://bugzilla.gnome.org/show_bug.cgi?id=758233