After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758230 - search provider: unnecessary error
search provider: unnecessary error
Status: RESOLVED FIXED
Product: gnome-contacts
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Contacts maintainer(s)
GNOME Contacts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-11-17 14:56 UTC by Matthias Clasen
Modified: 2015-11-17 15:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
search-provider: Don't dump core on timeout (1007 bytes, patch)
2015-11-17 15:04 UTC, Matthias Clasen 		committed Details | Review

Description Matthias Clasen 2015-11-17 14:56:46 UTC 
Looking at https://bugzilla.redhat.com/show_bug.cgi?id=1273946

it seems that timeouts while talking to eds gets caught in crash collection systems. I think it would be much better to log a warning and exit quietly.
Comment 1 Matthias Clasen 2015-11-17 15:04:31 UTC 
Created attachment 315757 [details] [review]
search-provider: Don't dump core on timeout

g_error is documented as "This function will result in a core dump".
It will get picked up by crash collection systems and cause noise
there, which is not helpful. Just log a warning and move on.
Comment 2 David King 2015-11-17 15:24:11 UTC 
Review of attachment 315757 [details] [review]:

Seems obviously correct to me.
Comment 3 Matthias Clasen 2015-11-17 15:25:26 UTC 
Attachment 315757 [details] pushed as c90c2b3 - search-provider: Don't dump core on timeout