After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758214 - Geolocation cancelled prematurely if language is selected
Geolocation cancelled prematurely if language is selected
Status: RESOLVED FIXED
Product: gnome-initial-setup
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Initial Setup maintainer(s)
GNOME Initial Setup maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-11-17 07:00 UTC by Tristan Van Berkom
Modified: 2015-11-17 08:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use GisPage->shown() vfunc instead of map signal (2.84 KB, patch)
2015-11-17 07:00 UTC, Tristan Van Berkom 		committed Details | Review

Description Tristan Van Berkom 2015-11-17 07:00:58 UTC 
Created attachment 315728 [details] [review]
Use GisPage->shown() vfunc instead of map signal

The GisTimezonePage implementation cancels geolocation lookup when the page is mapped.

However if a page is added to an already-mapped assistant, the child page is mapped immediately and not only when the child page is shown (this is normal, we've had the same behaviour historically with GtkNotebook).

When a language is changed, the assistant is visible and has all of its child pages rebuilt in the new locale automatically.

The result is that the timezone page cancels it's geolocation lookup immediately upon reconstruction, if a language is selected causing the assistant to rebuild.
Comment 1 Kalev Lember 2015-11-17 08:10:29 UTC 
Review of attachment 315728 [details] [review]:

Thanks for tracking that down! Just a small nitpick: maybe keep the comment in the renamed function?
Comment 2 Tristan Van Berkom 2015-11-17 08:19:18 UTC 
Review of attachment 315728 [details] [review]:

I re-added the comment which I accidentally dropped, and pushed.