After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758208 - GtkStackSwitcher should allow changing the icon size
GtkStackSwitcher should allow changing the icon size
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2015-11-17 02:55 UTC by Christian Hergert
Modified: 2015-11-17 05:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add GtkStackSwitcher:icon-size property (4.45 KB, patch)
2015-11-17 02:55 UTC, Christian Hergert 		committed Details | Review

Description Christian Hergert 2015-11-17 02:55:09 UTC 
Created attachment 315724 [details] [review]
add GtkStackSwitcher:icon-size property

For an incoming design in Builder, we need a bit more control over the icon size in the stack switcher. We could, of course, just make our own switcher, but this seems useful if the pattern catches on with other applications.

(We are using it for switching perspectives in Builder)

The attached patch adds a GtkStackSwitcher:icon-size property which works just like GtkImage:icon-size.
Comment 1 Matthias Clasen 2015-11-17 03:00:21 UTC 
Review of attachment 315724 [details] [review]:

Looks ok, with these fixes.

::: gtk/gtkstackswitcher.c
@@ +474,3 @@
+        {
+          clear_switcher (switcher);
+          populate_switcher (switcher);

Missing a g_object_notify here

@@ +570,3 @@
+                                                     0, G_MAXINT,
+                                                     GTK_ICON_SIZE_MENU,
+                                                     GTK_PARAM_READWRITE));

Should be G_PARAM_EXPLICIT_NOTIFY, or make distcheck will complain about excessive notification.

And please add a doc comment with a Since: tag.