After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758190 - gegl:pixbuf: The "pixbuf" property should be an object, not a raw pointer
gegl:pixbuf: The "pixbuf" property should be an object, not a raw pointer
Status: RESOLVED FIXED
Product: GEGL
Classification: Other
Component: operations
git master
Other All
: Normal normal
: ---
Assigned To: Default Gegl Component Owner
Default Gegl Component Owner
Depends on:
Blocks:
 
 
Reported: 2015-11-16 18:36 UTC by Debarshi Ray
Modified: 2015-11-16 18:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
operations/external/pixbuf: The "pixbuf" property should be an object (2.49 KB, patch)
2015-11-16 18:40 UTC, Debarshi Ray 		committed Details | Review
operations/common/copy-buffer: Clean up (1.35 KB, patch)
2015-11-16 18:41 UTC, Debarshi Ray 		none Details | Review
operations/common/copy-buffer: Clean up (1.40 KB, patch)
2015-11-16 18:42 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2015-11-16 18:36:42 UTC 
gegl:pixbuf's "pixbuf" property should be a GObject so that it can hold a reference on the GdkPixbuf. Otherwise, we will run into memory errors if the caller drops the last reference on the GdkPixbuf.
Comment 1 Debarshi Ray 2015-11-16 18:40:43 UTC 
Created attachment 315701 [details] [review]
operations/external/pixbuf: The "pixbuf" property should be an object
Comment 2 Debarshi Ray 2015-11-16 18:41:08 UTC 
Created attachment 315702 [details] [review]
operations/common/copy-buffer: Clean up
Comment 3 Debarshi Ray 2015-11-16 18:42:24 UTC 
Created attachment 315703 [details] [review]
operations/common/copy-buffer: Clean up

Forgot to add the bug URL.
Comment 4 Debarshi Ray 2015-11-16 18:46:01 UTC 
From #gegl on GIMPNet:
18:43 <pippin> rishi: push at will, making it be an object is more correct and  
      code should be fixed
Comment 5 Debarshi Ray 2015-11-16 18:46:55 UTC 
Pushed to master.

commit 014ec17796e0132601293cb0bc0f35ad1b68380f
Author: Debarshi Ray <debarshir@gnome.org>
Date:   Mon Nov 16 19:38:52 2015 +0100

    operations/common/copy-buffer: Clean up
    
    Let the chant system destroy the properties.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=758190

commit e4c3ad01adbb27c98132496edef44e6ab024418c
Author: Debarshi Ray <debarshir@gnome.org>
Date:   Mon Nov 16 19:36:52 2015 +0100

    operations/external/pixbuf: The "pixbuf" property should be an object
    
    https://bugzilla.gnome.org/show_bug.cgi?id=758190