GNOME Bugzilla – Bug 758182
Use icons in the selection toolbar
Last modified: 2015-11-30 16:39:06 UTC
Update the selection toolbar according to https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/collections/collections-wires-documents-main-window.png
Created attachment 315684 [details] [review] selections: Remove useless GtkRevealer It isn't necessary because GtkActionBar already contains a GtkRevealer.
Created attachment 315685 [details] [review] selections: Port to templates
Created attachment 315686 [details] [review] selection-toolbar: Rearrange buttons and use icons
Review of attachment 315684 [details] [review]: Good catch.
Review of attachment 315685 [details] [review]: Thanks, Alessandro. Looks good, apart from: ::: data/ui/selection-toolbar.ui @@ +6,3 @@ + <child> + <object class="GtkButton" id="toolbarOpen"> + <property name="visible">True</property> Please use 1 instead of 'True' and 0 instead of 'False'. I know it is not ideal, but otherwise gtk-builder-tool complains. @@ +15,3 @@ + <child> + <object class="GtkButton" id="toolbarPrint"> + <property name="visible">True</property> Ditto. @@ +24,3 @@ + <child> + <object class="GtkButton" id="toolbarTrash"> + <property name="visible">True</property> Ditto.
(In reply to Debarshi Ray from comment #5) > Review of attachment 315685 [details] [review] [review]: > > Thanks, Alessandro. Looks good, apart from: > > ::: data/ui/selection-toolbar.ui > @@ +6,3 @@ > + <child> > + <object class="GtkButton" id="toolbarOpen"> > + <property name="visible">True</property> > > Please use 1 instead of 'True' and 0 instead of 'False'. I know it is not > ideal, but otherwise gtk-builder-tool complains. > It complains ? I don't think it complains. It may silently change a True to a 1, but it will not tell you that True is wrong.
(In reply to Matthias Clasen from comment #6) > It complains ? I don't think it complains. It may silently change a True to > a 1, but it will not tell you that True is wrong. I meant that running 'gtk-builder-tool simplify' turns 'True' to 1.
Created attachment 315750 [details] [review] selections: Port to templates
Created attachment 315751 [details] [review] selection-toolbar: Rearrange buttons and use icons
Comment on attachment 315684 [details] [review] selections: Remove useless GtkRevealer Attachment 315684 [details] pushed as 13a001e - selections: Remove useless GtkRevealer
Comment on attachment 315750 [details] [review] selections: Port to templates Attachment 315750 [details] pushed as 21bfc56 - selections: Port to templates
Review of attachment 315751 [details] [review]: Looks great. Feel free to push after making this minor tweak: ::: data/ui/selection-toolbar.ui @@ +17,2 @@ <property name="visible">1</property> + <property name="orientation">GTK_ORIENTATION_VERTICAL</property> 'vertical', like we do elsewhere
Created attachment 316275 [details] [review] selection-toolbar: Rearrange buttons and use icons
Attachment 316275 [details] pushed as 1c0beeb - selection-toolbar: Rearrange buttons and use icons
Created attachment 316483 [details] [review] selection-toolbar: Replace tabs with spaces
Created attachment 316484 [details] [review] selection-toolbar: Add missing packing info
Review of attachment 316483 [details] [review]: Of course.
Review of attachment 316484 [details] [review]: ++
Attachment 316483 [details] pushed as 47d6017 - selection-toolbar: Replace tabs with spaces Attachment 316484 [details] pushed as 853bef0 - selection-toolbar: Add missing packing info