After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758150 - gedit 3.18.1 breaks synctex plugin
gedit 3.18.1 breaks synctex plugin
Status: RESOLVED DUPLICATE of bug 757963
Product: gedit-plugins
Classification: Other
Component: General
3.18.x
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2015-11-16 00:10 UTC by Germán Poo-Caamaño
Modified: 2019-03-23 20:51 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Germán Poo-Caamaño 2015-11-16 00:10:42 UTC
After upgrading gedit from 3.18.0 to 3.18.1 synctex stopped working.

It seems a change in the API (that should not happen in a stable release!) or maybe it is just me :-)

It turns out that doc.get_iter_at_line() now returns a tuple instead of just an iter.

@@ -110,7 +104,7 @@
         line_count = self._doc.get_line_count()
 
         for i in list(range(min(3,line_count))) + list(range(max(0,line_count - 3), line_count)):
-            result, start = self._doc.get_iter_at_line(i)
+            start = self._doc.get_iter_at_line(i)
             end = start.copy()
             end.forward_to_line_end()
             file_output = parse_modeline(self._doc.get_text(start, end, False))

I do not know if the change was actually intended or accidental. Therefore, I am not providing a proper patch.

It would be great to get some sort of feedback when a plugin is broken. The UI does not say anything, nor disable the plugin that is unable to load.
Comment 1 Ignacio Casal Quinteiro (nacho) 2015-11-16 09:06:49 UTC
I think this was reverted in gtk. Try to update it.
Comment 2 Sébastien Wilmet 2015-11-16 10:00:46 UTC
Yes the change was intended only for GTK+ master, but it has been backported accidentally. The return value of the function changed from void to gboolean, which is perfectly fine in C, but it breaks in some GI languages because the out parameter was already a return value… So the boolean return value has been removed. And the change has been reverted in 3.18.

*** This bug has been marked as a duplicate of bug 757963 ***