After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758107 - make check fails in git master (3.19.x)
make check fails in git master (3.19.x)
Status: RESOLVED FIXED
Product: geocode-glib
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: geocode-glib maintainer(s)
geocode-glib maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-11-14 15:16 UTC by Kjartan Maraas
Modified: 2015-12-16 15:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
test: Update test data against latest Nominatim data (2.17 KB, patch)
2015-11-23 19:06 UTC, Zeeshan Ali 		committed Details | Review

Description Kjartan Maraas 2015-11-14 15:16:45 UTC 
OK
  /geocode/reverse_fail:                                               OK
  /geocode/pub:                                                        **
ERROR:test-gcglib.c:240:test_pub: assertion failed (geocode_location_get_longitude (loc) == -0.5912356): (-0,5912357 == -0,5912356)
FAIL
GTester: last random seed: R02Sde02eeb4cc33d020a6758091168c29da
/bin/sh: line 1: 28110 Terminert               gtester --verbose test-geouri test-gcglib
Makefile:896: recipe for target 'test' failed
make[3]: *** [test] Error 143
Comment 1 Jonas Danielsson 2015-11-23 19:00:58 UTC 
We really should stop rely on this kind of data in check tests. It is a collaborative mapping service ... things are meant to change.
Comment 2 Zeeshan Ali 2015-11-23 19:06:59 UTC 
Created attachment 316113 [details] [review]
test: Update test data against latest Nominatim data

This fixes `make check`.
Comment 3 Bastien Nocera 2015-11-23 20:13:08 UTC 
(In reply to Jonas Danielsson from comment #1)
> We really should stop rely on this kind of data in check tests. It is a
> collaborative mapping service ... things are meant to change.

If you can find something that will test the sanity of the results and of the interaction with the server, I'd be fine with another test.
Comment 4 Zeeshan Ali 2015-11-30 16:55:20 UTC 
So shall I push the patch for now?
Comment 5 Zeeshan Ali 2015-12-16 15:01:32 UTC 
Attachment 316113 [details] pushed as 45837dc - test: Update test data against latest Nominatim data