After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758102 - Possibly accidental single quotation mark in end of string.
Possibly accidental single quotation mark in end of string.
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: Translations
git master
Other Linux
: Normal minor
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-11-14 13:33 UTC by Anders Jonsson
Modified: 2015-11-16 14:31 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Anders Jonsson 2015-11-14 13:33:50 UTC
Found a string oddity in libnm-core/nm-setting-ip-config.c:

family == AF_INET ? _("Missing IPv4 address") : _("Missing IPv6 address'"));


The ' in the end of the IPv6 string looks out of place, especially considering that the IPv4 string is missing it.
Comment 1 Anders Jonsson 2015-11-14 13:41:55 UTC
Found one more string issue, this time in clients/cli/settings.c:

"invalid option '%s', use  a combination of [%s] or 'ignore', 'default' or 'none'"


Here the space after "use" has been doubled.
Comment 2 Anders Jonsson 2015-11-15 22:06:34 UTC
One more string, this one is in two places, in libnm-core/nm-setting-cdma.c and in libnm-util/nm-setting-cdma.c:

"property is empty'"

In both it is unclear to me what the "'" in the end is doing there.
Comment 3 Anders Jonsson 2015-11-16 13:13:47 UTC
One final thing. When I used msgmerge to sync the translation to a pot file of the 1-0-branch gettext gave the following warning:

"warning: internationalized messages should not contain the '\r' escape sequence"


The string in question that set off the warning is:

#: ../clients/nm-online.c:96
#, c-format
msgid "\rConnecting"
Comment 4 Jiri Klimes 2015-11-16 14:31:30 UTC
The first three issues are typos, the last one is nm-online program exposing "\r" to translation strings.

All fixed now.

master:
2c8c4ce nm-online: do not put \r to a translatable string (bgo #758102)
b92397f all: fix typos in the code and update translations for that (bgo #758102)

nm-1-0
09d34ac nm-online: do not put \r to a translatable string (bgo #758102)
85a52fc all: fix typos in the code and update translations for that (bgo #758102)

Thanks a lot.