Agreed. The hard-coding of a bright theme despite the user's global settings is still an issue in 3.20.

Created attachment 336689 [details]
screenshot of Calendar with Dark theme forced using Inspector

This looks fine to me. Can that line in the source that forces off the user's gtk-application-prefer-dark-theme setting be removed so that users' choice is respected, please?

Calendar sticks out like a sore thumb for me and others who use dark themes, and in my case, it means I don't want to use it, which is a shame, as it seems to have lots of great features - and even more on the way. Hopefully including proper theme support. ;)

I found this post* where feaneron said:
>
> It’d be nice to have this bug opened upstream (at bugzilla.gnome.org),
> and I’ll appreciate if anyone do it.
>
> As mockups are designed for using the light variant of themes,
> we force Calendar to not use the dark one.

Most other GNOME mockups I've seen have been for light themes, yet those apps presumably trust the theme authors to provide defaults that work seamlessly in both light and dark variants. What's different here?

> Once we have mockups (or even reviews) about a dark-variant Calendar,
> we’ll push it to production.

Sure, then here's my screenshot and review: it looks fine. Please can we have it? :)

* https://feaneron.com/2015/05/18/what-to-expect-for-gnome-3-18/#comment-49

Created attachment 336691 [details] [review]
application: stop force disabling dark theme

Created attachment 336692 [details]
screenshot of Calendar with Dark theme forced using Inspector

(In reply to djb from comment #4)
> Created attachment 336692 [details]
> screenshot of Calendar with Dark theme forced using Inspector

There's a design reason why the app is forced to use the light theme. Maybe after all this time, designers can revisit this.

(In reply to Erick Perez Castellanos from comment #5)
> 
> There's a design reason why the app is forced to use the light theme. Maybe
> after all this time, designers can revisit this.

Thanks for the reply. Could you tell us what that reason is? I've not been able to find anything concrete written about it. And I don't use the Calendar enough to reveal all the problems, but that's in large part because it doesn't have a dark theme, so it's a bit of a Catch-22. :)

(In reply to djb from comment #6)
> (In reply to Erick Perez Castellanos from comment #5)
> > 
> > There's a design reason why the app is forced to use the light theme. Maybe
> > after all this time, designers can revisit this.
> 
> Thanks for the reply. Could you tell us what that reason is? I've not been
> able to find anything concrete written about it. And I don't use the
> Calendar enough to reveal all the problems, but that's in large part because
> it doesn't have a dark theme, so it's a bit of a Catch-22. :)

Oh, it hasn't been written anywhere else than in the code, :-). I rememeber when I started this talking with Lapo about the amount of chrome we wanted the app to have and how giving it a black theme might mislead the user in what is chrome and what is actual content in the app. But it is just a vague memory, that's why I said, we can/need/should engage with the design team about this issue again.

That's great, thank you!

Thanks for the patch. I'd like to point out something, though:

> This looks fine to me. Can that line in the source that forces off the
> user's gtk-application-prefer-dark-theme setting be removed so that users'
> choice is respected, please?

Pretty please, avoid this kind of passive aggressive comment. Bugzilla is a
place for technical discussion about the issues.

In the past, we disabled dark theme on GNOME Calendar because both Gtk+, Adwaita
and Calendar weren't in a good shape, and using the dark variant of the theme
was catastrophic. It still is not the best dark theme app out there, but at least
it's usable now.

This code was left in there because no one cared to provide a patch, until now -
thanks again for doing it.
Attachment 336691 [details] pushed as 0843f9e - application: stop force disabling dark theme

(In reply to Georges Basile Stavracas Neto from comment #9)
> 
> Pretty please, avoid this kind of passive aggressive comment. Bugzilla is a
> place for technical discussion about the issues.

OK, it does look worse than I really thought. I'm trying to be more constructive, so it helps if people politely point out where I've not been - so thanks for that.

> In the past, we disabled dark theme on GNOME Calendar because both Gtk+,
> Adwaita
> and Calendar weren't in a good shape, and using the dark variant of the theme
> was catastrophic. It still is not the best dark theme app out there, but at
> least
> it's usable now.

I'm glad my screenshot could show this! I'll try to give it a lot of testing once the next version hits, and report any remaining small oddities that I might find.

> This code was left in there because no one cared to provide a patch, until
> now -
> thanks again for doing it.

That's brilliant, thank you! If anyone ever asks why they should submit a patch, or thinks they won't get anywhere even though - or because - it's a small thing... then I'll show them this. :-)