GNOME Bugzilla – Bug 758041
tcpserversrc: blocksize property of basesrc has no effect
Last modified: 2018-11-03 11:43:52 UTC
tcpserversrc use the fixed max size for buffer which is 4K bytes. 'blocksize' property of basesrc has no effect on size of the buffers created by the tcpserversrc.
Created attachment 315386 [details] [review] tcpserversrc: using 'blocksize' property to decide max buffer size please review the patch
Review of attachment 315386 [details] [review]: ::: gst/tcp/gsttcpserversrc.c @@ +242,3 @@ if (avail > 0) { + g_object_get (src, "blocksize", &blocksize, NULL); + read = MIN (avail, blocksize); Use gst_base_src_get_blocksize() here instead. blocksize might also be -1 or 0, need to check for that. Not sure if this is the best idea though, if already more than blocksize is available on the socket in the receive buffer, there is not really a disadvantage of taking it all at once, or is there?
Created attachment 315390 [details] [review] tcpserversrc: using 'blocksize' property to decide max buffer size Please review updated patch as per review comments.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/244.