After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758041 - tcpserversrc: blocksize property of basesrc has no effect
tcpserversrc: blocksize property of basesrc has no effect
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-11-13 04:20 UTC by Prashant Gotarne
Modified: 2018-11-03 11:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tcpserversrc: using 'blocksize' property to decide max buffer size (1.51 KB, patch)
2015-11-13 04:20 UTC, Prashant Gotarne 		none Details | Review
tcpserversrc: using 'blocksize' property to decide max buffer size (1.55 KB, patch)
2015-11-13 09:16 UTC, Prashant Gotarne 		none Details | Review

Description Prashant Gotarne 2015-11-13 04:20:10 UTC 
tcpserversrc use the fixed max size for buffer which is 4K bytes. 
'blocksize' property of basesrc has no effect on size of the buffers created by the tcpserversrc.
Comment 1 Prashant Gotarne 2015-11-13 04:20:55 UTC 
Created attachment 315386 [details] [review]
tcpserversrc: using 'blocksize' property to decide max buffer size

please review the patch
Comment 2 Sebastian Dröge (slomo) 2015-11-13 08:46:43 UTC 
Review of attachment 315386 [details] [review]:

::: gst/tcp/gsttcpserversrc.c
@@ +242,3 @@
   if (avail > 0) {
+    g_object_get (src, "blocksize", &blocksize, NULL);
+    read = MIN (avail, blocksize);

Use gst_base_src_get_blocksize() here instead. blocksize might also be -1 or 0, need to check for that.

Not sure if this is the best idea though, if already more than blocksize is available on the socket in the receive buffer, there is not really a disadvantage of taking it all at once, or is there?
Comment 3 Prashant Gotarne 2015-11-13 09:16:55 UTC 
Created attachment 315390 [details] [review]
tcpserversrc: using 'blocksize' property to decide max buffer size

Please review updated patch as per review comments.
Comment 4 GStreamer system administrator 2018-11-03 11:43:52 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/244.