After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 758036 - Additional margin in the category view
Additional margin in the category view
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: General
3.18.x
Other All
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks: 758669
 
 
Reported: 2015-11-13 00:46 UTC by Alessandro Bono
Modified: 2015-11-30 15:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gnome-software-margin (570.53 KB, image/png)
2015-11-13 00:46 UTC, Alessandro Bono 		  Details
shell-category: Remove margins (1.23 KB, patch)
2015-11-13 00:47 UTC, Alessandro Bono 		needs-work Details | Review
shell-category: Move margins to another container (1.90 KB, patch)
2015-11-17 15:23 UTC, Alessandro Bono 		committed Details | Review

Description Alessandro Bono 2015-11-13 00:46:56 UTC 
Created attachment 315377 [details]
gnome-software-margin

Visible on the screenshot.
Comment 1 Alessandro Bono 2015-11-13 00:47:44 UTC 
Created attachment 315378 [details] [review]
shell-category: Remove margins
Comment 2 Kalev Lember 2015-11-13 10:46:54 UTC 
Review of attachment 315378 [details] [review]:

Thanks for the patch. I think a better solution than just removing the margins would be to add them to the margins inside the viewport, so that the margings for the unscrolled content stay the same.

Also, is it necessary to do <property name="margin_start">0</property> or can you just delete those lines with 0's?
Comment 3 Alessandro Bono 2015-11-17 15:23:18 UTC 
Add them inside the viewport gives the same effect (tiles are cropped). What about add the margins in category_detail_grid?
I'm ok with delete the lines with margin 0, I've kept them just for consistency with other parts of the source.
Comment 4 Alessandro Bono 2015-11-17 15:23:56 UTC 
Created attachment 315760 [details] [review]
shell-category: Move margins to another container
Comment 5 Kalev Lember 2015-11-17 15:30:13 UTC 
Review of attachment 315760 [details] [review]:

Thanks, looks good to me! That's exactly what I was thinking.
Comment 6 Alessandro Bono 2015-11-30 15:56:21 UTC 
Attachment 315760 [details] pushed as f22134f - shell-category: Move margins to another container