GNOME Bugzilla – Bug 758007
vaapipostproc: don't set caps change at first set
Last modified: 2015-11-19 11:30:30 UTC
When the source caps change, the filter is destroyed and recreated. Nonetheless, this happens every time the vaapipostproc starts, since the caps change algorithm does not take in consideration the first caps set. This patch intents to be an optimization, to avoid the destroy-creation cycle of the filter when the sources caps are set for the first time. Signed-off-by: Víctor Manuel Jáquez Leal <victorx.jaquez@intel.com>
Created attachment 315345 [details] [review] vaapipostproc: don't set caps change at first set
Created attachment 315693 [details] [review] vaapipostproc: params video_info_changed() callers The signature is video_info_changed(old_vip, new_vip). Nonetheless the callers swapped the the order. This didn't raise problems since the comparison of both structures were not affected by its semantics. But still it would be better to fix this to keep the coherence of the code. Signed-off-by: Víctor Manuel Jáquez Leal <victorx.jaquez@intel.com>
Created attachment 315694 [details] [review] vaapipostproc: don't set caps change at first set When the source caps change, the filter is destroyed and recreated. Nonetheless, this happens every time the vaapipostproc starts, since the caps change detection algorithm does not take in consideration when the caps are set by first time. This patch intents to be an optimization, to avoid a useless filter destroy-creation cycle when the sources caps are set for first time. Signed-off-by: Víctor Manuel Jáquez Leal <victorx.jaquez@intel.com>
Created attachment 315743 [details] [review] vaapipostproc: params video_info_changed() callers The signature is video_info_changed(old_vip, new_vip). Nonetheless the callers swapped the the order. This didn't raise problems since the comparison of both structures were not affected by its semantics. But still it would be better to fix this to keep the coherence of the code. Signed-off-by: Víctor Manuel Jáquez Leal <victorx.jaquez@intel.com>
Created attachment 315744 [details] [review] vaapipostproc: don't set caps change at first set When the source caps change, the filter is destroyed and recreated. Nonetheless, this happens every time the vaapipostproc starts, since the caps change detection algorithm does not take in consideration when the caps are set by first time. This patch intents to be an optimization, to avoid a useless filter destroy-creation cycle when the sources caps are set for first time. The new helper function video_info_update() is a refactorization to avoid duplicated code. Signed-off-by: Víctor Manuel Jáquez Leal <victorx.jaquez@intel.com>
Attachment 315743 [details] pushed as fc95852 - vaapipostproc: params video_info_changed() callers Attachment 315744 [details] pushed as 7578332 - vaapipostproc: don't set caps change at first set