Bug 757929 – tests:glcolorconvert: Fix caps memory leak

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 757929 - tests:glcolorconvert: Fix caps memory leak


Summary:	tests:glcolorconvert: Fix caps memory leak


Status:	RESOLVED FIXED

Product:	GStreamer
Classification:	Platform
Component:	gst-plugins-bad
Version:	git master
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	1.6.2
Assigned To:	GStreamer Maintainers
QA Contact:	GStreamer Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2015-11-11 07:06 UTC by Vineeth
Modified:	2015-11-11 10:44 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
fix caps memory leak (829 bytes, patch) 2015-11-11 07:07 UTC, Vineeth	committed	Details \| Review

Description Vineeth 2015-11-11 07:06:36 UTC

running tests on gstglcolorconvert is resulting in below memory leak

==6125== 31,210 (2,680 direct, 28,530 indirect) bytes in 67 blocks are definitely lost in loss record 1,688 of 1,692
==6125==    at 0x402C17C: malloc (in /usr/lib/valgrind/vgpreload_memcheck-x86-linux.so)
==6125==    by 0x42A8BE2: g_malloc (in /lib/i386-linux-gnu/libglib-2.0.so.0.4002.0)
==6125==    by 0x42BF281: g_slice_alloc (in /lib/i386-linux-gnu/libglib-2.0.so.0.4002.0)
==6125==    by 0x41517BB: gst_caps_new_empty (gstcaps.c:243)
==6125==    by 0x41519A3: gst_caps_new_simple (gstcaps.c:316)
==6125==    by 0x40AB83F: gst_video_info_to_caps (video-info.c:514)
==6125==    by 0x8049464: check_conversion.constprop.1 (gstglcolorconvert.c:176)
==6125==    by 0x804986A: test_reorder_buffer (gstglcolorconvert.c:227)
==6125==    by 0x410EBAA: srunner_run (check_run.c:450)
==6125==    by 0x410EC62: srunner_run_all (check_run.c:674)
==6125==    by 0x4101A97: gst_check_run_suite (gstcheck.c:825)
==6125==    by 0x8048F0C: main (gstglcolorconvert.c:246)

Comment 1 Vineeth 2015-11-11 07:07:45 UTC

Created attachment 315229 [details] [review]
fix caps memory leak

Comment 2 Matthew Waters (ystreet00) 2015-11-11 10:43:52 UTC

Thanks!

commit 5f8825e7d96f1e8cc2bf368e6dab413ed1f8a6c8
Author: Vineeth TM <vineeth.tm@samsung.com>
Date:   Wed Nov 11 16:06:25 2015 +0900

    tests:glcolorconvert: Fix caps memory leak
    
    Output caps being got from video info is not getting freed
    
    https://bugzilla.gnome.org/show_bug.cgi?id=757929

and 1.6 ae89eab816f2974f1ba9b5bb474a085640ffa4fe