After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757737 - Modernise GtkBuilder loading
Modernise GtkBuilder loading
Status: RESOLVED FIXED
Product: moserial
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: moserial-maint
moserial-maint
Depends on:
Blocks:
 
 
Reported: 2015-11-07 14:59 UTC by Bastien Nocera
Modified: 2015-11-10 17:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
data: Rename glade directory to ui (1.80 KB, patch)
2015-11-07 14:59 UTC, Bastien Nocera
none Details | Review
ui: Split up GtkBuilder file per-widget (198.01 KB, patch)
2015-11-07 14:59 UTC, Bastien Nocera
none Details | Review
ui: Load UI files from GResource (9.50 KB, patch)
2015-11-07 14:59 UTC, Bastien Nocera
none Details | Review
ui: Load UI files from GResource (10.35 KB, patch)
2015-11-09 15:56 UTC, Bastien Nocera
none Details | Review

Description Bastien Nocera 2015-11-07 14:59:08 UTC
.
Comment 1 Bastien Nocera 2015-11-07 14:59:12 UTC
Created attachment 315050 [details] [review]
data: Rename glade directory to ui

The format of the UI file is GtkBuilder, not glade.
Comment 2 Bastien Nocera 2015-11-07 14:59:24 UTC
Created attachment 315051 [details] [review]
ui: Split up GtkBuilder file per-widget
Comment 3 Bastien Nocera 2015-11-07 14:59:29 UTC
Created attachment 315052 [details] [review]
ui: Load UI files from GResource

Which shouldn't fail unless there's a programmer error.
Comment 4 Bastien Nocera 2015-11-09 15:56:05 UTC
Created attachment 315128 [details] [review]
ui: Load UI files from GResource

Which shouldn't fail unless there's a programmer error.
Comment 5 Michael Chudobiak 2015-11-10 15:06:39 UTC
I've committed these patches, but make distcheck chokes on this:

make[1]: *** No rule to make target '../../data/moserial.gresource.xml', needed by 'src/resources.c'.  Stop.
Comment 6 Bastien Nocera 2015-11-10 16:44:18 UTC
(In reply to Michael Chudobiak from comment #5)
> I've committed these patches, but make distcheck chokes on this:
> 
> make[1]: *** No rule to make target '../../data/moserial.gresource.xml',
> needed by 'src/resources.c'.  Stop.

I probably forgot to add something to the dist. I'll fix it up and re-upload patches, sorry about that.
Comment 7 Michael Chudobiak 2015-11-10 16:53:46 UTC
Just go ahead and commit a fix... I imagine it's a one-liner.
Comment 8 Bastien Nocera 2015-11-10 16:59:49 UTC
Indeed.

commit bb74c5d5abcb2609cb4a48e68a2a575e2aa51b8f
Author: Bastien Nocera <hadess@hadess.net>
Date:   Tue Nov 10 17:54:59 2015 +0100

    data: Fix typo that made distcheck fail
    
    https://bugzilla.gnome.org/show_bug.cgi?id=757737#c5
Comment 9 Michael Chudobiak 2015-11-10 17:58:59 UTC
Thanks!