GNOME Bugzilla – Bug 757733
Fix build on newer distributions
Last modified: 2015-11-10 14:17:47 UTC
.
Created attachment 315041 [details] [review] Fix failing initialisation Vala doesn't know how to assign a negative integer to a char. This would probably still fail on platforms where char is unsigned (like on PPC32).
Created attachment 315042 [details] [review] Disambiguate Gtk.ListStore usage Now that there's a liststore in both GTK+ and GLib.
Created attachment 315043 [details] [review] Port from long-obsolete gnome-doc-utils to yelp Allowing moserial to build on a recent distribution.
Created attachment 315048 [details] [review] doc: Port from long-obsolete gnome-doc-utils to yelp Allowing moserial to build on a recent distribution.
Created attachment 315049 [details] [review] build: Remove obsolete PKG_NAME From gnome-common: ***Warning*** PKG_NAME is deprecated, you may remove it from autogen.sh
Review of attachment 315042 [details] [review]: Thank you!
Review of attachment 315041 [details] [review]: Thanks! I patched this a little differently to avoid negative numbers entirely.
Review of attachment 315049 [details] [review]: Thanks!
Review of attachment 315043 [details] [review]: Earlier version of patch 315048, I think...
Review of attachment 315048 [details] [review]: Does this launch the manual correctly for you? I get "The URI ‘ghelp:moserial’ does not point to a valid page."
(In reply to Michael Chudobiak from comment #10) > Review of attachment 315048 [details] [review] [review]: > > Does this launch the manual correctly for you? I get "The URI > ‘ghelp:moserial’ does not point to a valid page." It opens the system-installed moserial help page, as yelp is installed system-wide for me. It might be that I broke installation of the documentation.
Created attachment 315129 [details] [review] doc: Port from long-obsolete gnome-doc-utils to yelp Allowing moserial to build on a recent distribution.
(In reply to Bastien Nocera from comment #12) > Created attachment 315129 [details] [review] [review] > doc: Port from long-obsolete gnome-doc-utils to yelp > > Allowing moserial to build on a recent distribution. That one worked, just needed to fix the call to yelp (might or might not have helped, but that's the right way to do things), and renaming the .xml files to index.docbook
Is there a reason the patch contains translated files like fr/index.docbook, instead of changing "moserial.xml" references to "index.docbook" in fr.po (for example)? It's been a while since I've done much work on gnome stuff, so I may have lost track of translation practices.
(In reply to Michael Chudobiak from comment #14) > Is there a reason the patch contains translated files like fr/index.docbook, > instead of changing "moserial.xml" references to "index.docbook" in fr.po > (for example)? > > It's been a while since I've done much work on gnome stuff, so I may have > lost track of translation practices. Looks at the patch once applied, I'm just renaming the moserial.xml to index.docbook, as expected by yelp. Those aren't translated through POTFILES (thankfully!).
Sorry, I'm still not getting it. I see that the master untranslated doc/C/moserial.xml was renamed to doc/C/index.docbook, but it was translated previously using translator files like doc/fr/fr.po. Are the translator files like doc/fr/fr.po obsolete now? Are they replaced by full files like doc/fr/index.docbook? Apologies if I'm being dense; I just don't want to offend the volunteer translators...
Created attachment 315182 [details] [review] doc: Port from long-obsolete gnome-doc-utils to yelp Allowing moserial to build on a recent distribution.
(In reply to Michael Chudobiak from comment #16) > Sorry, I'm still not getting it. I see that the master untranslated > doc/C/moserial.xml was renamed to doc/C/index.docbook, but it was translated > previously using translator files like doc/fr/fr.po. > > Are the translator files like doc/fr/fr.po obsolete now? Are they replaced > by full files like doc/fr/index.docbook? > > Apologies if I'm being dense; I just don't want to offend the volunteer > translators... No, you were right, I added generated files to git, which I shouldn't have. Seems to work now, let me know.
Review of attachment 315182 [details] [review]: Many thanks for the patches!