After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757678 - tests: Add more regression tests for (not nullable)
tests: Add more regression tests for (not nullable)
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2015-11-06 11:45 UTC by Philip Withnall
Modified: 2015-11-06 14:32 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tests: Add more regression tests for (not nullable) (17.80 KB, patch)
2015-11-06 11:45 UTC, Philip Withnall
committed Details | Review

Description Philip Withnall 2015-11-06 11:45:16 UTC
Patch attached to add some more regression tests for (not nullable) interaction with other annotations.
Comment 1 Philip Withnall 2015-11-06 11:45:20 UTC
Created attachment 314976 [details] [review]
tests: Add more regression tests for (not nullable)

On bug #719966, the question arose of whether parameters annotated with
(element-type) but not (not nullable) are regarded as nullable or
non-nullable.

Add some new unit tests to Regress-1.0.gir to check the behaviour is as
expected: annotating a parameter with (element-type) implicitly makes it
non-nullable (unless also annotated with (nullable)).
Comment 2 Colin Walters 2015-11-06 13:23:24 UTC
Review of attachment 314976 [details] [review]:

Nice!  Thanks.
Comment 3 Philip Withnall 2015-11-06 14:32:51 UTC
Attachment 314976 [details] pushed as d8e2574 - tests: Add more regression tests for (not nullable)