GNOME Bugzilla – Bug 757637
Include values in asset barchart
Last modified: 2018-06-29 23:44:26 UTC
Include the values in the bar labels of the assets barchart plot. This is useful for printouts or pdf exports where the tooltip with the actual value is not available.
Created attachment 314920 [details] [review] This patch adds the requested feature as a further option to the report See mailing list thread http://lists.gnucash.org/pipermail/gnucash-user/2015-November/062624.html
Review of attachment 314920 [details] [review]: Thank you for your patch. A few remarks: 1. I note you have added a new option of which the default behaviour changes the report compared to how it was (you chose to make your new option default to true, which means the amounts are added by default to the row labels). That is not good. Without explicit user action the report should continue to behave as it did before you added the option. Most users don't like it if their report layouts change without them choosing so. 2. Secondly I note you are going through a hoop to try and round the amounts to 2 decimal digits before inserting them in the row labels. What did trigger that ? I'm asking because IMO that's a bit of an arbitrary choice because not all currencies supported by gnucash round to 2 decimal digits so some users would find the new feature broken from the start. Maybe you could consider using gnucash' own xaccPrintAmount function to pretty print the amounts ? You can find example usage in other reports ? Other than that your patch is nice.
I tried to reply by email, but my email bounced with a request to use the web interface. I'll do it now, but I much prefer email. This web interface is cumbersome and time-consuming to use, in comparison. (In reply to Geert Janssens from comment #2) > 1. I note you have added a new option of which the default behaviour changes > the report compared to how it was (you chose to make your new option default > to true, which means the amounts are added by default to the row labels). > That is not good. Without explicit user action the report should continue to > behave as it did before you added the option. Most users don't like it if > their report layouts change without them choosing so. I agree with you. In general the new option should be off by default. I chose it to be on by default because that's how I like it better for me personally. Feel free to change it! > 2. Secondly I note you are going through a hoop to try and round the amounts > to 2 decimal digits before inserting them in the row labels. What did > trigger that ? I'm asking because IMO that's a bit of an arbitrary choice > because not all currencies supported by gnucash round to 2 decimal digits so > some users would find the new feature broken from the start. Maybe you could > consider using gnucash' own xaccPrintAmount function to pretty print the > amounts ? You can find example usage in other reports ? Yes, this was a quick hack. It was the first solution that came to my mind, and it works for me. Thanks for pointing out xaccPrintAmount, I did not know about that. Again, I'm happy if you improve the patch. > Other than that your patch is nice. Thanks. Best, JD
Would this patch be applied in a place that would address this issue in all the 'over time' reports, i.e. Assets over time, Liabilities over time and Net Worth over time barchart and linechart?
(In reply to David Carlson from comment #4) > Would this patch be applied in a place that would address this issue in all > the 'over time' reports, i.e. Assets over time, Liabilities over time and > Net Worth over time barchart and linechart? This patch applies only to the barcharts, but it should affect all of them.
GnuCash bug tracking has moved to a new Bugzilla host. The new URL for this bug is https://bugs.gnucash.org/show_bug.cgi?id=757637. Please continue processing the bug there and please update any external references or bookmarks.