After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757629 - vaapiencode: use pad query vmethods
vaapiencode: use pad query vmethods
Status: RESOLVED FIXED
Product: gstreamer-vaapi
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on: 757598
Blocks: 750547
 
 
Reported: 2015-11-05 12:17 UTC by Víctor Manuel Jáquez Leal
Modified: 2015-11-10 16:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
vaapiencode: use pad query vmethods (3.38 KB, patch)
2015-11-05 12:17 UTC, Víctor Manuel Jáquez Leal
committed Details | Review
plugin: guard pointers to pad query functions (2.49 KB, patch)
2015-11-05 12:17 UTC, Víctor Manuel Jáquez Leal
committed Details | Review

Description Víctor Manuel Jáquez Leal 2015-11-05 12:17:42 UTC
This is a continuation of commit 2f8c1159, where the pad query virtual methods
are implemented in the decoder. This patchset is the same for the encoder, and
guards the old pointers to pad query functions for old version of gstreamer,
so they can be safely removed when the support for gstreamer 1.2 be dropped.
Comment 1 Víctor Manuel Jáquez Leal 2015-11-05 12:17:47 UTC
Created attachment 314909 [details] [review]
vaapiencode: use pad query vmethods

GstVideoEncoder, the base class of vaapiencode, added support for pad queries
as virtual methods since gstreamer 1.4. This patch enables those vmethods,
while keeps support for previous versions of gstreamer.

This patch is relevant since GstVideoEncoder takes care of other queries that
we are currently ignoring.

Signed-off-by: Víctor Manuel Jáquez Leal <victorx.jaquez@intel.com>
Comment 2 Víctor Manuel Jáquez Leal 2015-11-05 12:17:52 UTC
Created attachment 314910 [details] [review]
plugin: guard pointers to pad query functions

Since gstreamer 1.4 is not required to have pad query functions if the query
vmethods are used.

This patch guards out the pad query functions for gstreamer < 1.4

Signed-off-by: Víctor Manuel Jáquez Leal <victorx.jaquez@intel.com>
Comment 3 Víctor Manuel Jáquez Leal 2015-11-10 16:51:06 UTC
Attachment 314909 [details] pushed as ea80207 - vaapiencode: use pad query vmethods
Attachment 314910 [details] pushed as 1efe569 - plugin: guard pointers to pad query functions