After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757609 - Deprecate GtkAction and friends
Deprecate GtkAction and friends
Status: RESOLVED FIXED
Product: glade
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Glade 3 Maintainers
Glade 3 Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-11-04 21:11 UTC by Ben
Modified: 2015-11-27 07:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
deprecate GtkAction (8.59 KB, patch)
2015-11-04 21:11 UTC, Ben 		accepted-commit_now Details | Review

Description Ben 2015-11-04 21:11:11 UTC 
Created attachment 314859 [details] [review]
deprecate GtkAction

GtkAction has been deprecated since GTK 3.10, so this patch marks it deprecated and moves the widgets into the 'Deprecated' section. This also deprecates all the GtkActivatable properties (e.g. look at the properties of a GtkButton in glade).
Comment 1 Ben 2015-11-04 21:19:55 UTC 
Maybe we should also disable the deprecated GtkActivatable properties so that they don't show up in the UI
Comment 2 Tristan Van Berkom 2015-11-25 11:12:38 UTC 
Review of attachment 314859 [details] [review]:

Looks good to me, sad to see them go though, was a lot of work to get all of that working well.

Please commit.
Comment 3 Tristan Van Berkom 2015-11-25 11:24:51 UTC 
(In reply to Ben from comment #1)
> Maybe we should also disable the deprecated GtkActivatable properties so
> that they don't show up in the UI

We will not be removing properties from the UI just because they are deprecated, as this will cause problems for people working on projects which either depend on older versions of GTK+, or are simply working on projects which have not yet migrated to GActions and GtkActionable properties yet.

However, we hope to find some solution which allows us to hide deprecated and typically unused properties from the UI and only show them in an "advanced mode" or such, as it's a delicate balance to both be a tool you can trust to work on the same project years after it was created, and also help guide the user by prioritizing the display of properties we consider to be more useful.