GNOME Bugzilla – Bug 757590
icon-utils: Add a for_scale() variant for gd_create_symbolic_icon
Last modified: 2015-11-04 18:30:15 UTC
It is incorrect to call gtk_icon_theme_lookup_by_gicon with a size multiplied by the scaling factor because the NxN@2 assets might be different from the 2Nx2N assets. In practice, it doesn't make a lot of difference in gnome-documents because we are using symbolics and the shapes are reasonably simple. However, gnome-photos' fork of the code uses a constant size for the emblem [1][2], instead of calculating it from the base_size, and not knowing the scale results in smaller emblems on HiDpi. So, other than being the right thing to do, it will help in re-uniting the fork. [1] https://git.gnome.org/browse/gnome-photos/commit/?id=2511cc5bb1ab5 [2] https://git.gnome.org/browse/gnome-photos/commit/?id=0cc1d70340553
Created attachment 314818 [details] [review] icon-utils: Fix annotation
Created attachment 314819 [details] [review] icon-utils: Add a for_scale() variant for gd_create_symbolic_icon
Review of attachment 314818 [details] [review]: OK
Review of attachment 314819 [details] [review]: Thanks, looks good to me.
Thanks, Cosimo.