After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757569 - rtspsrc: avoid potentially overflowing expression
rtspsrc: avoid potentially overflowing expression
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.8.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
1.6.4
Depends on:
Blocks:
 
 
Reported: 2015-11-04 09:01 UTC by jihae
Modified: 2016-04-20 13:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rtsp: avoid potentially overflowing expression (873 bytes, patch)
2015-11-04 09:01 UTC, jihae 		none Details | Review
rtsp: avoid potentially overflowing expression (821 bytes, patch)
2016-03-22 09:34 UTC, jihae 		committed Details | Review

Description jihae 2015-11-04 09:01:45 UTC 
Created attachment 314793 [details] [review]
rtsp: avoid potentially overflowing expression

static void
gst_rtspsrc_get_property (GObject * object, guint prop_id, GValue * value,
    GParamSpec * pspec)
{
...

    case PROP_TCP_TIMEOUT:
    {
      guint64 timeout;

      timeout = rtspsrc->tcp_timeout.tv_sec * G_USEC_PER_SEC +
          rtspsrc->tcp_timeout.tv_usec;


==> rtspsrc->tcp_timeout.tv_sec is glong. need type cast.
Comment 1 jihae 2016-03-22 09:34:26 UTC 
Created attachment 324526 [details] [review]
rtsp: avoid potentially overflowing expression
Comment 2 Sebastian Dröge (slomo) 2016-03-24 12:31:11 UTC 
commit da5c8a954c5d5f86cd650ef87cfbe569c964491b
Author: Jihae Yi <jihae.yi@samsung.com>
Date:   Wed Nov 4 14:51:19 2015 +0900

    rtspsrc: avoid potentially overflowing expression
    
    https://bugzilla.gnome.org/show_bug.cgi?id=757569