After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757564 - [PATCHes] Passwords’ and Cookies’ dialogs: Make search_bar toggleable.
[PATCHes] Passwords’ and Cookies’ dialogs: Make search_bar toggleable.
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Passwords, Cookies, & Certificates
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-11-04 05:58 UTC by Arnaud B.
Modified: 2015-11-05 20:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
cookies-dialog.ui: Make search_bar toggleable. (2.79 KB, patch)
2015-11-04 05:59 UTC, Arnaud B.
committed Details | Review
passwords-dialog.ui: Make search_bar toggleable. (2.81 KB, patch)
2015-11-04 06:00 UTC, Arnaud B.
committed Details | Review

Description Arnaud B. 2015-11-04 05:58:06 UTC
For both Passwords’ and Cookies’ dialogs, I don’t think that filtering using the SearchBar could be a so basic action that it should be displayed by default (I don’t have enough passwords for needing browsing, and I usually don’t look to a specific cookie).

Filtering results by the way causes problem with the understanding of what the “Remove all” buttons do. That’s an issue I won’t try to solve here, but making the SearchBar toogleable probably reduces this problem.

So, let’s make the SearchBar of each of these dialogs toggleable.
Comment 1 Arnaud B. 2015-11-04 05:59:02 UTC
Created attachment 314784 [details] [review]
cookies-dialog.ui: Make search_bar toggleable.
Comment 2 Arnaud B. 2015-11-04 06:00:16 UTC
Created attachment 314785 [details] [review]
passwords-dialog.ui: Make search_bar toggleable.