After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757492 - There is no false flag alert after explosion
There is no false flag alert after explosion
Status: RESOLVED FIXED
Product: gnome-mines
Classification: Applications
Component: general
3.18.x
Other All
: Normal normal
: ---
Assigned To: gnome-mines-maint
gnome-mines-maint
Depends on:
Blocks:
 
 
Reported: 2015-11-02 17:20 UTC by Danial Behzadi
Modified: 2015-11-03 17:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot (31.20 KB, image/png)
2015-11-02 17:20 UTC, Danial Behzadi
Details

Description Danial Behzadi 2015-11-02 17:20:22 UTC
Created attachment 314671 [details]
Screenshot

If you set a mine flag on a clear cell, after the explosion of a mine, you should be able to see which flag was false.
For example, See the cell on the right bottom of the exploded mine in the Screenshot attached, which says there is 3 mines near it. As you see one flag is inappropriate (the right neighbour of exploded mine), but there is no sign which tell the user that was wrong.
Comment 1 Michael Catanzaro 2015-11-02 18:14:17 UTC
Strange, I thought we at least used to show this.
Comment 2 Robert Roth 2015-11-02 20:14:49 UTC
(In reply to Michael Catanzaro from comment #1)
> Strange, I thought we at least used to show this.

I am sure we had it, and we did not deliberately remove it. I will look around and see if I can find anything related, but there have been no changes regarding the game logic recently (at least since the theming engine introduction), so it's not a recent change, but nevertheless, I might be the one to blame for it.
Comment 3 Robert Roth 2015-11-03 13:38:00 UTC
Ok, took a look, the background color was set to red for incorrectly flagged fields, but the default and the classic themes had overridden the css style, thus this only worked in the colored background theme. 
Now I have updated the code and images with a separate image for incorrect flag (per theme), so a theme can now set both the image and the background for incorrectly flagged fields.
* coloured background theme only sets the background to red
* the default theme only sets the image to a red version of the flag
* the classic theme sets the background.

These look reasonable enough for me. My only question is whether this can go into the stable release (this is a minor UI change - as part of a bugfix), but will try to get an answer for that. I would like to include this in 3.18.2, as I see no risk in it, but if it's not recommended, it will have to wait for 3.19.2.

This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.
Comment 4 Michael Catanzaro 2015-11-03 17:05:26 UTC
Yes, it can go into the stable release. The UI freeze is there to discourage you from making big UI changes, not to stop you from fixing bugs! Mines has had an unusually high amount of bug reports since 3.18.0 was released, and it would be good to get those all fixed in 3.18.2.