After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757480 - Use GST_STIME_FORMAT and GST_STIME_ARGS with GstClockTimeDiff
Use GST_STIME_FORMAT and GST_STIME_ARGS with GstClockTimeDiff
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal minor
: 1.7.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-11-02 14:16 UTC by Luis de Bethencourt
Modified: 2015-11-02 15:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for tests/examples/seek/scrubby.c (937 bytes, patch)
2015-11-02 14:16 UTC, Luis de Bethencourt 		committed Details | Review

Description Luis de Bethencourt 2015-11-02 14:16:59 UTC 
Created attachment 314641 [details] [review]
patch for tests/examples/seek/scrubby.c

GST_STIME_FORMAT and GST_STIME_ARGS where added to gstreamer/gst/gstclock.h in 2015-06-15, but it looks like not all instances of GstClockTimeDiff were changed to use these.

I attach an example of this switch to using these macros that handle the potential negative values of GstClockTimeDiff better.

If this looks good, I can fix all other instances.
Comment 1 Nicolas Dufresne (ndufresne) 2015-11-02 15:08:44 UTC 
Review of attachment 314641 [details] [review]:

Looks good. Feel free to port where needed, having a -00:01 instead of a big value is always better in traces.
Comment 2 Luis de Bethencourt 2015-11-02 15:49:42 UTC 
Awesome. Thanks for both the review and for writing GST_STIME_FORMAT and GST_STIME_ARGS Nicolas! :)
Comment 3 Luis de Bethencourt 2015-11-02 15:52:03 UTC 
Review of attachment 314641 [details] [review]:

commit fcfb9a77943d5954aca3b4c6f3176a5b64a6ec7f
Author: Luis de Bethencourt <luisbg@osg.samsung.com>
Date:   Mon Nov 2 14:06:39 2015 +0000

    examples: use GST_STIME_FORMAT for GstClockTimeDiff

    GST_STIME_FORMAT is more appropriate for GstClockTimeDiff since it can
    handle negative values better.

    https://bugzilla.gnome.org/show_bug.cgi?id=757480