GNOME Bugzilla – Bug 757464
Move 'Repeat Keys' options from the Keyboard panel to the Universal Access panel
Last modified: 2015-11-04 12:03:25 UTC
Created attachment 314621 [details] screenshot with the new Keyboard panel design, settings such as the Repeat Keys toggle, speed, and delay belong to the Universal Access panel. https://wiki.gnome.org/Design/SystemSettings/Keyboard#Experimental_Guidelines The following patch adds the Repeat Keys entry to the Typing section of the Universal Access panel. It needs UI review. For that, I would suggest: - Should we have marks on the sliders? - Are the labels good enough? - Having the On/Off switch in the header bar is a good choice?
Created attachment 314622 [details] [review] universal-access: add Repeat Keys to the Typing section According to the new Keyboard panel design, this setting belongs to the Universal Access panel.
Review of attachment 314622 [details] [review]: The first comment is that, from the screenshot, the sliders should be disabled if repeat keys are disabled. Apart from the 2 comments, looks fine to me. ::: panels/universal-access/cc-ua-panel.c @@ +94,3 @@ #define GSD_MOUSE_SETTINGS "org.gnome.settings-daemon.peripherals.mouse" #define KEY_DOUBLE_CLICK_DELAY "double-click" +#define GSD_KEYBOARD_SETTINGS "org.gnome.settings-daemon" You're not using this, are you?
Created attachment 314638 [details] screencast (In reply to Bastien Nocera from comment #2) > Review of attachment 314622 [details] [review] [review]: > > The first comment is that, from the screenshot, the sliders should be > disabled if repeat keys are disabled. right. I took the screenshot before binding the switch to the set sensitive calls. > > Apart from the 2 comments, looks fine to me. > > ::: panels/universal-access/cc-ua-panel.c > @@ +94,3 @@ > #define GSD_MOUSE_SETTINGS > "org.gnome.settings-daemon.peripherals.mouse" > #define KEY_DOUBLE_CLICK_DELAY "double-click" > +#define GSD_KEYBOARD_SETTINGS "org.gnome.settings-daemon" > > You're not using this, are you? nope.
Created attachment 314639 [details] [review] universal-access: add Repeat Keys to the Typing section According to the new Keyboard panel design, this setting belongs to the Universal Access panel.
Review of attachment 314639 [details] [review]: There's no code to handle the sensitivity of the repeat settings when the switch is off, that I can see. Did you upload an old patch? ::: panels/universal-access/cc-ua-panel.c @@ +94,3 @@ #define GSD_MOUSE_SETTINGS "org.gnome.settings-daemon.peripherals.mouse" #define KEY_DOUBLE_CLICK_DELAY "double-click" +#define GSD_KEYBOARD_SETTINGS "org.gnome.settings-daemon" If you're not using it, why do you keep adding it?
Created attachment 314648 [details] [review] universal-access: add Repeat Keys to the Typing section According to the new Keyboard panel design, this setting belongs to the Universal Access panel.
(In reply to Bastien Nocera from comment #5) > Review of attachment 314639 [details] [review] [review]: > > There's no code to handle the sensitivity of the repeat settings when the > switch is off, that I can see. > > Did you upload an old patch? my bad. that was the case. The sensitivity is handled on on_repeat_keys_toggled. > > ::: panels/universal-access/cc-ua-panel.c > @@ +94,3 @@ > #define GSD_MOUSE_SETTINGS > "org.gnome.settings-daemon.peripherals.mouse" > #define KEY_DOUBLE_CLICK_DELAY "double-click" > +#define GSD_KEYBOARD_SETTINGS "org.gnome.settings-daemon" > > If you're not using it, why do you keep adding it? removed.
You already committed that patch, probably by error. Can you fix the expanded switch in the dialog?
Created attachment 314808 [details] [review] universal-access: prevent the Repeat Keys switch from vexpanding
Review of attachment 314808 [details] [review]: Looks good.