GNOME Bugzilla – Bug 757449
udpsink: new unit test exposing IPv6 handling of IPv4 socket
Last modified: 2018-01-17 14:19:18 UTC
In the first patch in the series I add a new unit test for udpsink that attempts to set QoS DSCP for an IPv4 socket previously given to the sink. This results in the following error message: 0:00:00.053175184 24469 0x1711e60 ERROR multiudpsink gstmultiudpsink.c:1056:gst_multiudpsink_setup_qos_dscp:<udpsink> could not set TCLASS: Protocol not available Which, while true, is not pretty. The second patch in the series queries the family of the socket before attempting to use setsockopt() to set IPV6_TCLASS.
Created attachment 314597 [details] [review] Proposed patch 1/2
Created attachment 314598 [details] [review] Proposed patch 2/2
Comment on attachment 314598 [details] [review] Proposed patch 2/2 Should the other one also only be done if the socket family is V4?
Perhaps, let me look into this a bit further.
commit 5091b5f39ffd22052802c1c41ee568fef65efeb5 (HEAD -> master) Author: Sebastian Rasmussen <sebrn@hotmail.com> Date: Mon Nov 2 00:41:28 2015 +0100 multiudpsink: don't try to set IPV6_TCLASS on IPV4 sockets Avoids ERROR log message. https://bugzilla.gnome.org/show_bug.cgi?id=757449 commit 0d57709d388f548910dcab8b193ef85bb0de7341 Author: Sebastian Rasmussen <sebrn@hotmail.com> Date: Mon Nov 2 00:41:28 2015 +0100 tests: udpsink: add check that sets QoS on IPv4/6 sockets https://bugzilla.gnome.org/show_bug.cgi?id=757449
*** Bug 782864 has been marked as a duplicate of this bug. ***