GNOME Bugzilla – Bug 757439
Middle click on folder in path bar causes hiding animation
Last modified: 2017-06-19 10:20:05 UTC
If I middle click on the path bar, the folder opens in a new tab but there is also an animation to hide the window. Immediately after that the window appears again.
This only happens when "/org/gnome/desktop/wm/preferences/action-middle-click-titlebar" is set to "minimize".
Created attachment 353992 [details] [review] Patch for button_event_cb in pathbar This suggested change handles the middle click (like the right click) already on the button-press-event and not the button-release-event.
Review of attachment 353992 [details] [review]: Code looks good! Can you write a proper commit message? Some guidelines: https://wiki.gnome.org/Newcomers/SubmitPatch
Review of attachment 353992 [details] [review]: ::: src/nautilus-pathbar.c @@ +1534,3 @@ return TRUE; } + else if (event->button == 2 && mask == 0) Could you maybe use GDK_BUTTON_MIDDLE instead of the 2 there? It’s more readable that way. @@ +1553,3 @@ } + if (event->button == 1 && mask == GDK_CONTROL_MASK) Same here, but GDK_BUTTON_PRIMARY.
Created attachment 353999 [details] [review] nautilus-pathbar: Handle middle click on button press I changed the numbers to gdk constants and added more explanation to the commit message.
(In reply to elias from comment #5) > Created attachment 353999 [details] [review] [review] > nautilus-pathbar: Handle middle click on button press > > I changed the numbers to gdk constants and added more explanation to the > commit message. I think you forgot to commit your changes. :p
Created attachment 354030 [details] [review] nautilus-pathbar: Handle middle click on button press This time with comitted changes...
Review of attachment 354030 [details] [review]: Looks good, thanks.
Attachment 354030 [details] pushed as e671217 - pathbar: Handle middle click on button-press-event