After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757414 - [PATCHes] clear-data-dialog.ui: Unbloat.
[PATCHes] clear-data-dialog.ui: Unbloat.
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-31 17:02 UTC by Arnaud B.
Modified: 2015-11-01 15:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
clear-data-dialog.ui: Manually unbloat. (12.14 KB, patch)
2015-10-31 17:02 UTC, Arnaud B. 		committed Details | Review
clear-data-dialog.ui: Make unresizable. (1.22 KB, patch)
2015-10-31 17:03 UTC, Arnaud B. 		committed Details | Review
clear-data-dialog.ui: Kill a level of GtkBox. (8.18 KB, patch)
2015-10-31 17:04 UTC, Arnaud B. 		committed Details | Review
ClearDataDialog: Define signals in the UI file. (5.73 KB, patch)
2015-10-31 17:04 UTC, Arnaud B. 		committed Details | Review
ClearDataDialog: Default dialog to only clear cache. (3.61 KB, patch)
2015-10-31 17:05 UTC, Arnaud B. 		committed Details | Review

Description Arnaud B. 2015-10-31 17:02:09 UTC 
Here is a set of patches to clean the code of the ClearDataDialog’s class.
Comment 1 Arnaud B. 2015-10-31 17:02:53 UTC 
Created attachment 314552 [details] [review]
clear-data-dialog.ui: Manually unbloat.
Comment 2 Arnaud B. 2015-10-31 17:03:28 UTC 
Created attachment 314553 [details] [review]
clear-data-dialog.ui: Make unresizable.
Comment 3 Arnaud B. 2015-10-31 17:04:05 UTC 
Created attachment 314554 [details] [review]
clear-data-dialog.ui: Kill a level of GtkBox.
Comment 4 Arnaud B. 2015-10-31 17:04:36 UTC 
Created attachment 314555 [details] [review]
ClearDataDialog: Define signals in the UI file.
Comment 5 Arnaud B. 2015-10-31 17:05:09 UTC 
Created attachment 314556 [details] [review]
ClearDataDialog: Default dialog to only clear cache.
Comment 6 Michael Catanzaro 2015-11-01 14:09:33 UTC 
Review of attachment 314552 [details] [review]:

r+
Comment 7 Michael Catanzaro 2015-11-01 14:09:46 UTC 
Review of attachment 314553 [details] [review]:

r+
Comment 8 Michael Catanzaro 2015-11-01 14:10:17 UTC 
Review of attachment 314554 [details] [review]:

LGTM
Comment 9 Michael Catanzaro 2015-11-01 14:13:05 UTC 
Review of attachment 314555 [details] [review]:

::: src/clear-data-dialog.c
@@ +141,2 @@
 static void
+clear_data_dialog_class_init (ClearDataDialogClass *klass)

And after moving update_flags below, in the next patch, class_init has found its way to be right above the instance init, which is the best place anyway.
Comment 10 Michael Catanzaro 2015-11-01 14:14:36 UTC 
Review of attachment 314556 [details] [review]:

Yup