After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757406 - Patch for additional keyboard short-cuts for launching new games
Patch for additional keyboard short-cuts for launching new games
Status: RESOLVED FIXED
Product: gnome-mines
Classification: Applications
Component: general
git master
Other Linux
: Normal enhancement
: ---
Assigned To: gnome-mines-maint
gnome-mines-maint
Depends on:
Blocks:
 
 
Reported: 2015-10-31 10:54 UTC by Isaac Lenton
Modified: 2015-11-04 07:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (3.01 KB, patch)
2015-10-31 11:22 UTC, Isaac Lenton 		committed Details | Review

Description Isaac Lenton 2015-10-31 10:54:04 UTC 
The number keys 1-4 are currently unbound.  Using these keys as short-cuts to launch small, medium, large and custom games simplifies playing gnome-mines with the keyboard.

The Escape key is also bound for navigating back to the new game screen if the current game has not yet been started.

Patch to be attached shortly.
Comment 1 Isaac Lenton 2015-10-31 11:22:02 UTC 
Created attachment 314535 [details] [review]
Proposed patch
Comment 2 Robert Roth 2015-11-03 13:44:23 UTC 
Review of attachment 314535 [details] [review]:

Looks fine, and it eases the keyboard-only use of the game.
Comment 3 Michael Catanzaro 2015-11-03 17:07:24 UTC 
Isaac, if you have a GNOME git account, and can go ahead and push this to master, then great... if not, let us know and we'll commit for you.
Comment 4 Isaac Lenton 2015-11-04 02:57:11 UTC 
Hi Michael, I don't have a GNOME git account.
Comment 5 Robert Roth 2015-11-04 07:27:08 UTC 
Thanks for the patch, and for your huge batch of contributions.