After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757366 - tracker_miner_manager_index_file should return TRUE on success
tracker_miner_manager_index_file should return TRUE on success
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: General
1.2.x
Other All
: Normal normal
: ---
Assigned To: tracker-general
tracker-general
Depends on:
Blocks:
 
 
Reported: 2015-10-30 14:50 UTC by Debarshi Ray
Modified: 2015-10-30 15:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
libtracker-control: Fix the return value (882 bytes, patch)
2015-10-30 14:55 UTC, Debarshi Ray
committed Details | Review
libtracker-control: Improve the documentation (1.75 KB, patch)
2015-10-30 15:26 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2015-10-30 14:50:16 UTC
tracker_miner_manager_index_file returns FALSE both on success and failure. This is obviously wrong.
Comment 1 Debarshi Ray 2015-10-30 14:55:34 UTC
Created attachment 314491 [details] [review]
libtracker-control: Fix the return value
Comment 2 Debarshi Ray 2015-10-30 15:26:38 UTC
Created attachment 314496 [details] [review]
libtracker-control: Improve the documentation
Comment 3 Carlos Garnacho 2015-10-30 15:31:49 UTC
Review of attachment 314491 [details] [review]:

Oops, indeed
Comment 4 Carlos Garnacho 2015-10-30 15:32:33 UTC
Review of attachment 314496 [details] [review]:

Yup, I agree that's more accurate
Comment 5 Debarshi Ray 2015-10-30 15:39:15 UTC
Pushed to master, and all the way back to tracker-1.2.