GNOME Bugzilla – Bug 757349
new download arrow (in master > 3.18) is black even in dark theme
Last modified: 2015-12-07 19:21:46 UTC
Hi, the (very cool) new progress download arrow is hard to read when using gtk dark theme. It should be white on black (as other icons), not black on black. Cheers, Jérémy
Created attachment 314447 [details] screenshot
Wow, it's not a real icon, but drawn by cairo... interesting approach; I guess it would work if we can figure out how to get the right colors from the theme.
Nautilus 3.18.1 has a nice progress icon (in the form of a round timer) that has the same problem too.
Created attachment 315003 [details] nautilus black on black too
Nautilus was already fixed in bug #756803. I'll just copy what they did....
Created attachment 315066 [details] [review] ephy-download-progress-icon: Use theme colors Based on the corresponding nautilus fix by Elias Aebi.
Review of attachment 315066 [details] [review]: ::: lib/widgets/ephy-downloads-progress-icon.c @@ +56,3 @@ + style_context = gtk_widget_get_style_context (widget); + gtk_style_context_get_color (style_context, gtk_widget_get_state_flags (widget), &color); + color.alpha = progress == 1 ? 1 : 0.2; you should probably multiply the alpha by 0.2 instead of overriding it in case the theme color uses an alpha value @@ +72,3 @@ cairo_clip (cr); + color.alpha = 0.7; here as well
Thanks for the review! I'll change that to multiplication.
Created attachment 315973 [details] [review] ephy-download-progress-icon: Use theme colors Based on the corresponding nautilus fix by Elias Aebi.
Ping Carlos
Attachment 315973 [details] pushed as 15b634b - ephy-download-progress-icon: Use theme colors