After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 757349 - new download arrow (in master > 3.18) is black even in dark theme
new download arrow (in master > 3.18) is black even in dark theme
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Downloads
git master
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2015-10-30 10:48 UTC by kapouer
Modified: 2015-12-07 19:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (7.61 KB, image/png)
2015-10-30 10:50 UTC, kapouer
  Details
nautilus black on black too (145.82 KB, image/png)
2015-11-06 15:40 UTC, kapouer
  Details
ephy-download-progress-icon: Use theme colors (1.91 KB, patch)
2015-11-08 00:40 UTC, Michael Catanzaro
none Details | Review
ephy-download-progress-icon: Use theme colors (1.91 KB, patch)
2015-11-20 14:48 UTC, Michael Catanzaro
committed Details | Review

Description kapouer 2015-10-30 10:48:08 UTC
Hi,

the (very cool) new progress download arrow is hard to read
when using gtk dark theme.
It should be white on black (as other icons), not black on black.

Cheers,
Jérémy
Comment 1 kapouer 2015-10-30 10:50:23 UTC
Created attachment 314447 [details]
screenshot
Comment 2 Michael Catanzaro 2015-10-30 17:32:23 UTC
Wow, it's not a real icon, but drawn by cairo... interesting approach; I guess it would work if we can figure out how to get the right colors from the theme.
Comment 3 kapouer 2015-11-06 15:40:16 UTC
Nautilus 3.18.1 has a nice progress icon (in the form of a round timer) that has the same problem too.
Comment 4 kapouer 2015-11-06 15:40:56 UTC
Created attachment 315003 [details]
nautilus black on black too
Comment 5 Michael Catanzaro 2015-11-08 00:39:52 UTC
Nautilus was already fixed in bug #756803. I'll just copy what they did....
Comment 6 Michael Catanzaro 2015-11-08 00:40:05 UTC
Created attachment 315066 [details] [review]
ephy-download-progress-icon: Use theme colors

Based on the corresponding nautilus fix by Elias Aebi.
Comment 7 eyelash 2015-11-17 21:16:24 UTC
Review of attachment 315066 [details] [review]:

::: lib/widgets/ephy-downloads-progress-icon.c
@@ +56,3 @@
+  style_context = gtk_widget_get_style_context (widget);
+  gtk_style_context_get_color (style_context, gtk_widget_get_state_flags (widget), &color);
+  color.alpha = progress == 1 ? 1 : 0.2;

you should probably multiply the alpha by 0.2 instead of overriding it in case the theme color uses an alpha value

@@ +72,3 @@
     cairo_clip (cr);
 
+    color.alpha = 0.7;

here as well
Comment 8 Michael Catanzaro 2015-11-20 14:37:24 UTC
Thanks for the review! I'll change that to multiplication.
Comment 9 Michael Catanzaro 2015-11-20 14:48:09 UTC
Created attachment 315973 [details] [review]
ephy-download-progress-icon: Use theme colors

Based on the corresponding nautilus fix by Elias Aebi.
Comment 10 Michael Catanzaro 2015-12-07 11:17:52 UTC
Ping Carlos
Comment 11 Michael Catanzaro 2015-12-07 19:21:37 UTC
Attachment 315973 [details] pushed as 15b634b - ephy-download-progress-icon: Use theme colors